Date: Tue, 30 Apr 2013 09:22:40 -0400 From: Juan Mojica <jmojica@gmail.com> To: "Li, Qing" <qing.li@bluecoat.com> Cc: FreeBSD Net <freebsd-net@freebsd.org>, "qingli@freebsd.org" <qingli@freebsd.org> Subject: Re: in_lltable_rtcheck Message-ID: <CAPKuH-ynQxMnH9YARPU51fDS8HXRmHZ1PN9oZpkaddTc=4B5tw@mail.gmail.com> In-Reply-To: <B143A8975061C446AD5E29742C531723355A0C82@pwsvl-excmbx-04.internal.cacheflow.com> References: <CAPKuH-yfJf0EMyz1iEQ%2BkMz%2BenxRrfhDcpOcMJQfLjJYx10jRQ@mail.gmail.com> <B143A8975061C446AD5E29742C531723355A0C82@pwsvl-excmbx-04.internal.cacheflow.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Great! Thanks Qing. I'll come up with a patch and reply. -Juan On Mon, Apr 29, 2013 at 9:40 PM, Li, Qing <qing.li@bluecoat.com> wrote: > The problem you described here seemed familiar so I checked into the svn > history, > and found I have in fact fixed this issue in other parts of the code. > > Please see > http://svnweb.freebsd.org/base?view=revision&revision=186708 > > So I think similar fix should be applied here as well. > > --Qing > > > ________________________________________ > From: owner-freebsd-net@freebsd.org [owner-freebsd-net@freebsd.org] on > behalf of Juan Mojica [jmojica@gmail.com] > Sent: Monday, April 29, 2013 6:17 PM > To: FreeBSD Net > Subject: in_lltable_rtcheck > > Why is the code comparing the entire sockaddr structure instead of just the > relevant fields? We have a flood of the log message below when > transitioning an IP address from one port to another. And this triggers > other behavior as well. > > Through GDB, we can see that the addresses are in the same subnet. The > problem is that the sin_port port fields in the l3addr and in sa do not > match. > > Is there a reason sin_port should be compared here? > > I can come up with a patch, that's not an issue, but I wanted to confirm > with others first. > > > if (!(rt->rt_flags & RTF_HOST) && rt->rt_ifp != ifp) { > const char *sa, *mask, *addr, *lim; > int len; > > mask = (const char *)rt_mask(rt); > /* > * Just being extra cautious to avoid some custom > * code getting into trouble. > */ > if (mask == NULL) { > RTFREE_LOCKED(rt); > return (EINVAL); > } > > sa = (const char *)rt_key(rt); > addr = (const char *)l3addr; > len = ((const struct sockaddr_in *)l3addr)->sin_len; > lim = addr + len; > > for ( ; addr < lim; sa++, mask++, addr++) { > if ((*sa ^ *addr) & *mask) { > #ifdef DIAGNOSTIC > log(LOG_INFO, "IPv4 address: \"%s\" is not > on the network\n", > inet_ntoa(((const struct sockaddr_in > *)l3addr)->sin_addr)); > #endif > RTFREE_LOCKED(rt); > return (EINVAL); > } > } > } > > > Regards > > -- > Juan Mojica > Email: jmojica@gmail.com > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > -- Juan Mojica Email: jmojica@gmail.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPKuH-ynQxMnH9YARPU51fDS8HXRmHZ1PN9oZpkaddTc=4B5tw>