Date: Sun, 19 Jul 2015 19:10:44 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: "O'Connor, Daniel" <darius@dons.net.au> Cc: Tim Kientzle <tim@kientzle.com>, Rick Macklem <rmacklem@uoguelph.ca>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: -current broken when MAKEOBJDIRPREFIX is set (was: src is on NFS) Message-ID: <14459.1437358244@chaos> In-Reply-To: <B1562B35-9B2A-40BA-85C6-A644467CE03D@dons.net.au> References: <1C5FC434-0646-40E5-83AC-A0DE486D3273@dons.net.au> <1589003792.10086361.1437048709012.JavaMail.zimbra@uoguelph.ca> <D0292F78-AE59-4E02-B24F-420129832A47@dons.net.au> <DDD4254F-FD46-4155-8644-2F274AE9AE16@kientzle.com> <BCA54145-46C0-4976-A530-5CCF8B4CAC56@dons.net.au> <6668.1437240399@chaos> <FB13089A-4562-4FCB-ADCD-039A1A2E90E0@dons.net.au> <15209.1437332341@chaos> <B1562B35-9B2A-40BA-85C6-A644467CE03D@dons.net.au>
next in thread | previous in thread | raw e-mail | index | archive | help
O'Connor, Daniel <darius@dons.net.au> wrote: > >> So, it seems MAKEOBJDIRPREFIX only works as an environmental variable > Weird, I could have sworn I have set it on the command line and had it > work, but.. In most "normal" usage you will likely not notice a difference. It is only when a makefile is "being clever" that things go south when you break its expectations. > > I thought there was a check in src/Makefile for that. > > Not so far as I can tell - it certainly gets quite far before blowing > up with a non useful error message :) The check in src/Makefile is only guarding against MAKEOBJDIRPREFIX set in say make.conf, it explicitly discards the possibility of setting MAKEOBJDIRPREFIX on command line - which seems wrong. Also with bmake, you *can* usefully set MAKEOBJDIRPREFIX in a makefile since the choice of .OBJDIR can be made after make starts reading makefiles. So the current test is perhaps out dated on that score too - though only if something like auto.obj.mk is being used (-DWITH_AUTO_OBJ) which I don't think I've tested with buildworld.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14459.1437358244>