Date: Wed, 20 Apr 2011 01:51:30 -0600 From: Warner Losh <imp@bsdimp.com> To: Brandon Gooch <jamesbrandongooch@gmail.com> Cc: freebsd-acpi@FreeBSD.org Subject: Re: [PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs Message-ID: <E2F33180-1878-4659-977F-2DA1118A75D4@bsdimp.com> In-Reply-To: <BANLkTi=8e96iGKTYXtCmMn5goArSyyee%2Bw@mail.gmail.com> References: <20110420003133.4dc391f6.taku@tackymt.homeip.net> <20110420004614.3099947d.taku@tackymt.homeip.net> <BANLkTikBxPq5xG1v_KzFszxkLO44UKzxGw@mail.gmail.com> <EEFD8EF7-35C7-422B-AF3A-60004630089C@bsdimp.com> <BANLkTi=8e96iGKTYXtCmMn5goArSyyee%2Bw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Apr 19, 2011, at 2:24 PM, Brandon Gooch wrote: > On Tue, Apr 19, 2011 at 3:02 PM, Warner Losh <imp@bsdimp.com> wrote: >> Having chased boogiemen in this area before, I think this patch makes = good sense even though it breaks the device model a little. However, = the hardware in question really is special on x86... >>=20 >> Warner >=20 > Sorry Warner, would you mind elaborating on the above? Do you mean > that the patch moves to being too x86-specific for syscons handling? I mean that this device is special in the architecture, so having some = special code to cope with it is ok. Warner >=20 > Sorry if I'm being too dense. >=20 > -Brandon >=20 >> On Apr 19, 2011, at 12:48 PM, Brandon Gooch wrote: >>=20 >>> On Tue, Apr 19, 2011 at 10:46 AM, Taku YAMAMOTO = <taku@tackymt.homeip.net> wrote: >>>> On Wed, 20 Apr 2011 00:31:33 +0900 >>>> Taku YAMAMOTO <taku@tackymt.homeip.net> wrote: >>>>=20 >>>>> A patch is attached. >>>> Mailman ate it ;) >>>> Here it is. >>>>=20 >>>> -- >>>> -|-__ YAMAMOTO, Taku >>>> | __ < <taku@tackymt.homeip.net> >>>>=20 >>>> - A chicken is an egg's way of producing more eggs. - >>>>=20 >>>=20 >>> Throughout testing, I've seen zero regressions. In fact, an issue = that >>> existed prior to this patch involving minor screen corruption (dirty >>> VGA buffers) is gone (Intel Mobile 965 Express). >>>=20 >>> Thank you so much guys! >>>=20 >>> -Brandon >=20 >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E2F33180-1878-4659-977F-2DA1118A75D4>