Date: Sun, 26 Jun 2011 12:47:59 +0400 From: "Ilya A. Arkhipov" <micro@heavennet.ru> To: Chris Rees <crees@freebsd.org> Cc: ports@freebsd.org, kwm@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, Ion-Mihai Tetcu <itetcu@freebsd.org>, Joe Marcus Clarke <marcus@freebsd.org> Subject: Re: portlint(1) knobs order: let's make things more logical Message-ID: <BANLkTim4aKW9n1qE_UR6toQdSZ%2BEye_D9A@mail.gmail.com> In-Reply-To: <BANLkTikr9k-w-XrjYOhaRubYXDc9EjPfYw@mail.gmail.com> References: <20110622020048.GA83940@FreeBSD.org> <BANLkTi=En%2B7nJgEmKCmBEQMwiV0nbcPhEg@mail.gmail.com> <20110622064224.GB94185@FreeBSD.org> <BANLkTi=s6zYOJJv6%2Bkk%2Bttd7jadmTuaT6w@mail.gmail.com> <20110622160233.8b6156e1.itetcu@FreeBSD.org> <20110622135941.GA99725@FreeBSD.org> <e645505a-06bd-461d-b4a6-3f4436caef24@email.android.com> <BANLkTim%2B46u3H9tUp-EqS1PKKtfKZ2KQTw@mail.gmail.com> <20110623033052.GA23118@FreeBSD.org> <BANLkTi=fiYsp-fJY97TkTyXWOCS0-CrQTg@mail.gmail.com> <20110623083351.GA51681@FreeBSD.org> <BANLkTin3McVv=8f7LAr_KFUJxNbn-ncw4g@mail.gmail.com> <BANLkTikqeYV2Asg02%2BpvkGf3inW9yCVqBg@mail.gmail.com> <4E052ADA.8050200@freebsd.org> <BANLkTinoPey7Y-V_RCqh631whPiiJYxScQ@mail.gmail.com> <BANLkTimtJAZU7CwYcoGgABPHWQ%2BnfqPXHg@mail.gmail.com> <BANLkTikr9k-w-XrjYOhaRubYXDc9EjPfYw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
26 июня 2011 г. 12:22 пользователь Chris Rees <crees@freebsd.org> написал: > > On 26 Jun 2011 09:16, "Ilya A. Arkhipov" <micro@heavennet.ru> wrote: > > > > 25 июня 2011 г. 15:52 пользователь Ilya A. Arkhipov <micro@heavennet.ru> > написал: > > > >> > >> > >> 25 июня 2011 г. 4:24 пользователь Joe Marcus Clarke <marcus@freebsd.org> > написал: > >> > >>> On 6/24/11 8:16 AM, Ilya A. Arkhipov wrote: > >>> > 23 июня 2011 г. 21:52 пользователь Ilya A. Arkhipov < > micro@heavennet.ru>написал: > >>> > > >>> >> СС: to eitan@eitanadler.com > >>> > > >>> > > >>> > Hi danfe@, marcus@ and all > >>> > > >>> > What you say about this patch(in attach)? > >>> > > >>> > ps. sorry i can't test patch on my work > >>> > >>> Thanks. Can you submit this as a PR so I can track it. I have a > >>> portlint commit coming up soon. > >>> > >>> Joe > >>> > >>> -- > >>> Joe Marcus Clarke > >>> FreeBSD GNOME Team :: gnome@FreeBSD.org > >>> FreeNode / #freebsd-gnome > >>> http://www.FreeBSD.org/gnome > >> > >> > >> All patch have error's... > >> if we use "&checkorder('LICENSE', $tmp, $file," that this block > invariable, but there is no license at all. > >> Also if try: > >> print "OK: checking fourth section of $file (LICENSE).\n" > >> if ($verbose); > >> $tmp = $sections[$idx]; > >> > >> if ($tmp =~ /LICENSE/) { > >> > >> &checkorder('LICENSE', $tmp, $file, qw( > >> LICENSE LICENSE_COMB LICENSE_GROUPS LICENSE_NAME > >> > >> LICENSE_TEXT LICENSE_FILE LICENSE_PERMS > >> )); > >> $tmp may not contain license example: > >> 13 MAINTAINER= ports@FreeBSD.org > >> 14 COMMENT= Versatile softsynth implemented as a DSSI plugin > >> 15 > >> 16 BUILD_DEPENDS= ${LOCALBASE}/include/dssi.h:${PORTSDIR}/audio/dssi > \ > >> 17 ${LOCALBASE}/include/ladspa.h:${PORTSDIR}/audio/ladspa > >> 18 LIB_DEPENDS= > dssialsacompat.0:${PORTSDIR}/audio/libdssialsacompat \ > >> 19 lo.7:${PORTSDIR}/audio/liblo \ > >> 20 jack.0:${PORTSDIR}/audio/jack \ > >> 21 fftw3f.5:${PORTSDIR}/math/fftw3-float > >> 22 > >> 23 LICENSE= GPLv2 LGPL21 > >> > >> Any ideas.. > >> > >> > >> -- > >> Best regards. > >> Ilya A. Arkhipov > >> > > > > Hi All, > > > > Please test this patch > http://micro.heavennet.ru/ports/portlint/portlint.patch > > > > > > Did you send a PR? It'd be much easier for us to track. > > Chris > PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=158306 -- Best regards. Ilya A. Arkhipov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTim4aKW9n1qE_UR6toQdSZ%2BEye_D9A>