Date: Thu, 26 May 2011 19:05:10 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: mdf@FreeBSD.org Cc: Attilio Rao <attilio@FreeBSD.org>, src-committers@FreeBSD.org, Pawel Jakub Dawidek <pjd@FreeBSD.org>, svn-src-user@FreeBSD.org Subject: Re: svn commit: r222060 - in user/avg/xcpu/sys: kern sys Message-ID: <4DDE7A36.2050104@FreeBSD.org> In-Reply-To: <BANLkTim_zEDPANqZTpyYdOKqDaPEc8EhVg@mail.gmail.com> References: <201105181508.p4IF8UoS096841@svn.freebsd.org> <20110518182441.GB2273@garage.freebsd.pl> <4DD4243C.4070301@FreeBSD.org> <BANLkTikAnB-3XbvDwGHgyqyJquH9BhqzOQ@mail.gmail.com> <4DDD13F9.5040800@FreeBSD.org> <4DDE7555.7090500@FreeBSD.org> <BANLkTim_zEDPANqZTpyYdOKqDaPEc8EhVg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
on 26/05/2011 18:46 mdf@FreeBSD.org said the following: > A per-thread flag is needed as long as other CPUs can be running or > even just the scheduler on the remaining CPU. So I would thing that > flag needs to be checked until the system has been massaged to the > state you describe above. I am not sure that I understand your reasoning if you mean that the flag needs to be checked in TD_IS_INPANIC. That is, right now there is no TD_IS_INPANIC and things work after panic to a certain degree. I do not intend to improve that degree and just want to keep an option to revert to the current state of matters. When TD_IS_INPANIC is introduced and stop_cpus_on_panic==1, then there will be only one thread left running after panic, that will be the thread that called panic, checking TDF_INPANIC just doesn't add anything. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DDE7A36.2050104>