Date: Thu, 30 Jun 2011 08:19:15 +0100 From: Chris Rees <crees@freebsd.org> To: Scot Hetzel <swhetzel@gmail.com> Cc: ports@freebsd.org, ohauer@freebsd.org Subject: Re: Call for testers -- CONF_FILES variable Message-ID: <BANLkTimj3akz8qfhUiYXAWHKh01%2BOPpsvg@mail.gmail.com> In-Reply-To: <BANLkTin4o93SyRpFy-i9bUDH%2B1tS1dXGeg@mail.gmail.com> References: <BANLkTikvMU2dK=aN=hFgxA8wfvUitmfbRA@mail.gmail.com> <BANLkTin4o93SyRpFy-i9bUDH%2B1tS1dXGeg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 30 June 2011 00:26, Scot Hetzel <swhetzel@gmail.com> wrote: > On Wed, Jun 29, 2011 at 3:24 PM, Chris Rees <crees@freebsd.org> wrote: >> Dear all, >> >> I've rewritten the CONF_FILES handling after talking to bapt@, and >> I've done away with the >> colon-separated tuples -- they're overcomplicated. >> >> The result is something like MAN and PORTDOCS (indeed most of the code >> is stolen from PORTDOCS). >> >> This means that shell globs, filenames and directories are specified >> in CONF_FILES, but the sample file is installed in the Makefile as >> .pkgconf. >> >> Examples for MailScanner [1] show how it can replace huge trees of >> config files, and for portscout [2] shows how it is used for just one >> file. >> >> Look at how much has been removed from the MailScanner plist and >> pkg-*install.in files -- there are three screens of unused functions >> that could also be chopped out now too! >> >> I'm asking people to (if they want) try out the new variable, and let >> me know what they like and don't like about it. >> >> Since bapt@ is sort of sponsoring this and isn't back for ~ two weeks >> it won't make it in before then at least, but some testing and >> feedback would be fantastic! >> >> http://people.freebsd.org/~crees/patches/bsd-port-mk-conf-files-plist-only-pkgconf.diff >> > I like this change, as it standardizes the use of config files. > >> >> [1] http://people.freebsd.org/~crees/patches/mailscanner-conf-files.diff > > files/pkg-install.in > - upgrade_lang_conf this should stay as it automates the upgrade from > a old lang conf file to the new version. > - change the .sample to .pkgconf in the upgrade_lang_conf and > upgrade_mailscanner_conf functions. > Thanks for the feedback. Please bear in mind that I spent ~2 minutes chopping parts out of pkg-install with little regard for other functionality; I just wanted an example. Rest assured I'll do it 'properly' when I apply the patch for real. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTimj3akz8qfhUiYXAWHKh01%2BOPpsvg>