Date: Tue, 23 Dec 2008 19:09:24 -0500 From: Eitan Adler <eitanadlerlist@gmail.com> To: Garrett Cooper <yanefbsd@gmail.com> Cc: "ports@freebsd.org" <ports@freebsd.org>, Doug Barton <dougb@FreeBSD.org> Subject: Re: proposal: add --disable-tests to www/firefox3 port Message-ID: <49517DB4.1060704@gmail.com> In-Reply-To: <BBBD0841-1639-4D64-BAA2-0B8108226BFF@gmail.com> References: <49504D4B.8040402@gmail.com> <49515A77.3050204@FreeBSD.org> <BBBD0841-1639-4D64-BAA2-0B8108226BFF@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>> Perhaps this could be part of the WITH_DEBUG option?
Like this?
--- firefox3/Makefile 2008-12-19 15:13:01.000000000 -0500
+++ firefox-new/Makefile 2008-12-23 19:07:09.000000000 -0500
@@ -57,6 +57,10 @@
.include <bsd.port.pre.mk>
+.if defined(WITHOUT_DEBUG)
+MOZ_OPTIONS+= --disable-tests
+.endif
+
GECKO_PTHREAD_LIBS!=${CC} -dumpspecs | ${GREP} -m 1 '%{\!pg:
%{pthread:' | ${SED} -e 's|^.*%{\!pg: %{pthread:|| ; s|}.*$$||' || ${TRUE}
Also
WARN: Makefile: [SMB is listed in OPTIONS, but neither WITH_SMB nor
WITHOUT_SMB appears.]:
WARN: Makefile: [LOGGING is listed in OPTIONS, but neither WITH_LOGGING
nor WITHOUT_LOGGING appears.]:
WARN: Makefile: [OPTIMIZED_CFLAGS is listed in OPTIONS, but neither
WITH_OPTIMIZED_CFLAGS nor WITHOUT_OPTIMIZED_CFLAGS appears.]:
Are they used at all? should they just be removed?
--
Eitan Adler
GNU Key fingerprint: 2E13 BC16 5F54 0FBD 62ED 42B6 B65F 24AB E9C2 CCD1
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49517DB4.1060704>