Date: Tue, 12 Feb 2008 10:29:35 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-acpi@freebsd.org Cc: njl@freebsd.org, Andriy Gapon <avg@icyb.net.ua> Subject: Re: probable typo in acpi_cpu.c Message-ID: <200802121029.35850.jhb@freebsd.org> In-Reply-To: <C2E075B0-4092-40A4-B054-DB722F3E7AC1@FreeBSD.org> References: <47B0BCA2.6040204@icyb.net.ua> <C2E075B0-4092-40A4-B054-DB722F3E7AC1@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 11 February 2008 06:59:19 pm Rui Paulo wrote:
>
> On Feb 11, 2008, at 9:22 PM, Andriy Gapon wrote:
>
> >
> > There is probably a typo in acpi_cpu.c, function acpi_cpu_startup:
> > if (cpu_quirks && CPU_QUIRK_NO_C3) { <----- here
> > sc->cpu_cx_count = sc->cpu_non_c3 + 1;
> > }
> >
> > Not sure how that affects the logic though.
>
> You are right. This means that the C3 state will still be available on
> systems like those based on PIIX4.
>
> Nate, could you please commit a fix for it?
I've committed it, but I don't think it has that affect. Instead,
CPU_QUIRK_NO_C3 is always true, so it basically boils down to
if (cpu_quirks) {
/* Disable C3 */
}
So I think the result is that C3 is disabled for other quirks (i.e. the
NO_BM_CTRL quirk). This includes SMP machines that don't have _CST.
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200802121029.35850.jhb>