Date: Wed, 18 Mar 2015 11:59:38 -0400 From: Anthony Jenkins <Anthony.B.Jenkins@att.net> To: Warner Losh <imp@bsdimp.com> Cc: freebsd-acpi@freebsd.org, Ian Smith <smithi@nimnet.asn.au> Subject: Re: [PATCH] ACPI CMOS region support rev. 5 Message-ID: <5509A0EA.4070208@att.net> In-Reply-To: <C47B4C39-A568-47AE-A62F-1DE69CF9E43C@bsdimp.com> References: <20150222180817.GD27984@strugglingcoder.info> <54EB8C21.2080600@att.net> <2401337.2oUs7iAbtB@ralph.baldwin.cx> <54EF3D5D.4010106@att.net> <20150227222203.P38620@sola.nimnet.asn.au> <20150228125857.D1277@besplex.bde.org> <54F14368.4020807@att.net> <20150302002647.W42658@sola.nimnet.asn.au> <54F5E53D.1090601@att.net> <20150306025800.U46361@sola.nimnet.asn.au> <54F9D7E6.4050807@att.net> <5504FF32.3020202@att.net> <20150317001401.X22641@sola.nimnet.asn.au> <5506F00A.3030708@att.net> <5506FBE3.1000009@att.net> <20150317041624.K22641@sola.nimnet.asn.au> <55073442.5060005@att.net> <C47B4C39-A568-47AE-A62F-1DE69CF9E43C@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/18/2015 11:26 AM, Warner Losh wrote: > Looking at patch 5: > > You need to rework this so there’s an atrtc_acpi.c. Put all the ACPI attachment in there. Okay, shouldn't be a problem. > You should also split off the little bit that’s ISA-specific into atrtc_isa. You mean rtcin() and writertc()? ...but that's not my stuff, it was already in atrtc.c. PNP0800 (the PC-AT RTC component) is (practically) an ISA-specific device. Anthony > Once you do that, we can talk. > > Warner >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5509A0EA.4070208>