Date: Tue, 19 Mar 2024 12:41:15 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: =?UTF-8?Q?Einar_Bjarni_Halld=C3=B3rsson?= <einar@isnic.is> Cc: Gleb Popov <arrowd@freebsd.org>, ports@freebsd.org Subject: Re: Multiple new R ports Message-ID: <CAFDf7UJF4r=2E_X2YvSrYxzqCePR%2Boj0YVgMmOtayydROYfLsw@mail.gmail.com> In-Reply-To: <C99D8CBC-B355-4361-8976-54E833B59311@isnic.is> References: <44F61FC1-532F-447F-80E9-83ED37599CD7@isnic.is> <CALH631nPt94VcQnsh5_CQHnGkb-5uVvRotFGWWoj4wRtNveXUQ@mail.gmail.com> <AD61A7F4-D5CC-487D-A08A-47267FD69052@isnic.is> <16c2bf5c-9022-4ce9-9283-838f99d80ba3@isnic.is> <CAFDf7U%2BG2v5eQ2OJq76d2f3UGht9J1kTstFECAaqqnPPq5QUvA@mail.gmail.com> <2E6761A6-F462-4B83-94AC-9658583A581D@isnic.is> <6A36BE5B-2C76-434D-8EFF-D9518DA7E6E6@isnic.is> <CAFDf7ULvnKOEfKQ392wX9NZr5E_wAyDvJ7BMe5Q-HfxLfA6iLg@mail.gmail.com> <06222A4D-6C49-4320-8599-8E7668885BDE@isnic.is> <CAFDf7UKzzUxT97hkxnV5Fjxr4p7xpp=-mDQKR%2Bdbvia-0kLhtQ@mail.gmail.com> <C3B4CFBA-628C-42D5-85E9-391CC9F11F19@isnic.is> <CAFDf7U%2BAuzgufnPJJedj0_frY0bNje-HxdtXy83dJOnN5hXw4w@mail.gmail.com> <531E6E65-EF0A-4246-AFCB-152368451EAF@isnic.is> <CAFDf7UL3-k65pRZoQRYGthb6JJW7NQRTQB8b_NtrNdoLJzgSWQ@mail.gmail.com> <77026901-2B83-481D-ADE9-9093530D6326@isnic.is> <C99D8CBC-B355-4361-8976-54E833B59311@isnic.is>
next in thread | previous in thread | raw e-mail | index | archive | help
The correct way is to update diff in review so maintainer and reviewers can take a look, do some tests and give approval if ok. Cheers, Einar Bjarni Halld=C3=B3rsson <einar@isnic.is> escreveu (ter=C3=A7a, 19/03/= 2024 =C3=A0(s) 12:27): > > > > On 19 Mar 2024, at 12:12, Einar Bjarni Halld=C3=B3rsson <einar@isnic.is= > wrote: > >> There's a missing dependency that needs to be added to fix build. > >> You should have received an e-mail from review. > >> > > > > I did. I=E2=80=99m sorry I missed it :( > > > > I made a mistake when I tried to update the diff revision and unrelated c= hanges went in, along with > the updated dependencies. > > Should I attempt to revert the changes and update the diff again, or is t= here another simple way to just revert > last changes? > > .einar --=20 Nuno Teixeira FreeBSD Committer (ports)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UJF4r=2E_X2YvSrYxzqCePR%2Boj0YVgMmOtayydROYfLsw>