Date: Wed, 26 Aug 2015 17:28:50 +0900 From: Yonghyeon PYUN <pyunyh@gmail.com> To: Johann Hugo <jhugo@meraka.csir.co.za> Cc: Roosevelt Littleton <knowledgeispower80@gmail.com>, freebsd-stable@freebsd.org Subject: Re: msk msk0 watchdog timeout freeze hang lock stop problem Message-ID: <20150826082850.GC971@michelle.fasterthan.com> In-Reply-To: <CAAU5ZLM%2B8bxGFa9QR-nrY77NfrKozkz-_8eeZd3kt13CX1a4DQ@mail.gmail.com> References: <CAA_tkETEHPWKWtZejsD12Lo_TaU7Ywf6KLmXd_u0DVMcXLXK8g@mail.gmail.com> <20150816120831.GB1288@michelle.fasterthan.com> <CAAU5ZLM%2B8bxGFa9QR-nrY77NfrKozkz-_8eeZd3kt13CX1a4DQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Qxx1br4bt0+wmkIi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 26, 2015 at 10:06:29AM +0200, Johann Hugo wrote: > 10.2-RELEASE does not work for me. It works for a very short while and > then it stops with "msk0 watchdog timeout" errors > Thanks a lot for your report. This is the first report for msk(4) watchdog timeouts on 10.2-RELEASE. > I'm not sure what patch Roosevelt was talking about, but the patch in > this thread works for me: > https://lists.freebsd.org/pipermail/freebsd-stable/2015-April/082226.html > > I've changed MSK_STAT_ALIGN from 4096 to 8192 in if_mskreg.h and it's > been running stable for the last week. > I see. I'm under the impression that RX/TX descriptor ring alignment shall trigger the same issue so it would be better to know how attached patch works on your box. Thanks. > Johann > > On Sun, Aug 16, 2015 at 2:08 PM, Yonghyeon PYUN <pyunyh@gmail.com> wrote: > > On Wed, Aug 12, 2015 at 09:44:06AM -0400, Roosevelt Littleton wrote: > >> Hi, > >> So, I can confirm with the attached patch. I have a working msk0 that > >> hasn't failed for the past month. I considered this problem fix for me. > >> Since, I have went a long time without any problems. Thanks! > > > > I'm not sure which patch you used. Given that users reported > > 10.2-RELEASE works, it would be great if you revert local patch > > and try it again on 10.2-RELEASE. --Qxx1br4bt0+wmkIi Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="msk.align.diff" Index: sys/dev/msk/if_mskreg.h =================================================================== --- sys/dev/msk/if_mskreg.h (revision 281587) +++ sys/dev/msk/if_mskreg.h (working copy) @@ -2175,13 +2175,8 @@ #define MSK_ADDR_LO(x) ((uint64_t) (x) & 0xffffffffUL) #define MSK_ADDR_HI(x) ((uint64_t) (x) >> 32) -/* - * At first I guessed 8 bytes, the size of a single descriptor, would be - * required alignment constraints. But, it seems that Yukon II have 4096 - * bytes boundary alignment constraints. - */ -#define MSK_RING_ALIGN 4096 -#define MSK_STAT_ALIGN 4096 +#define MSK_RING_ALIGN 32768 +#define MSK_STAT_ALIGN 32768 /* Rx descriptor data structure */ struct msk_rx_desc { --Qxx1br4bt0+wmkIi--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150826082850.GC971>