Date: Fri, 04 Jan 2013 10:25:53 +0100 From: olli hauer <ohauer@gmx.de> To: freebsd-ports@freebsd.org Cc: Scot Hetzel <swhetzel@gmail.com>, Miroslav Lachman <000.fbsd@quip.cz> Subject: Re: What is policy about auto-editing config files on port install / deinstall? Message-ID: <50E6A021.9000203@gmx.de> In-Reply-To: <CACdU%2Bf-_0X08Y86jg8HLoQgQGKRdmgsVT=e4jvXGs-ZLGB3%2BSg@mail.gmail.com> References: <50E49A73.2070008@quip.cz> <CACdU%2Bf9WKAsLZHqHMZKtgGoBRL%2BR9do0qfTL0d_c_8_e6Tb4bw@mail.gmail.com> <50E5FCDA.80906@quip.cz> <CACdU%2Bf__iAzrOoSOHunb3x7Ot7usZ7zjfhT%2Bz95uTy8HUqr83g@mail.gmail.com> <CACdU%2Bf-_0X08Y86jg8HLoQgQGKRdmgsVT=e4jvXGs-ZLGB3%2BSg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2013-01-04 09:51, Scot Hetzel wrote:
> On Fri, Jan 4, 2013 at 2:12 AM, Scot Hetzel <swhetzel@gmail.com> wrote:
>>>
>>> Why am I forced to manualy re-enable all 3rd party modules on each upgrade?
>>>
>>> Modules should not disable something that is explicitly enabled by user /
>>> system administrator.
>>>
>>>
>> I found the cause of your issue, the www/mod_sendfile/Makefile has
>> AP_GENPLIST= yes defined. This causes the port to use this code to
>> create the packing list:
>>
>> Mk/bsd.apache.mk
>>
>> 451 ap-gen-plist:
>> 452 .if defined(AP_GENPLIST)
>> 453 . if !exists(${PLIST})
>> 454 @${ECHO} "===> Generating apache plist"
>> 455 # apache22
>> 456 @${ECHO} "@unexec ${SED} -i '' -E
>> '/LoadModule[[:blank:]]+%%AP_NAME%%_module/d'
>> %D/%%APACHEETCDIR%%/httpd.conf" >> ${PLIST}
>
> Found the reason for this sed line, as it is used to remove the
> LoadModule line from the httpd.conf file so that when Apache is
> uninstalled, the httpd.conf could be removed, if there were no changes
> from the original.
>
> see http://svnweb.freebsd.org/ports?view=revision&revision=194395
>
> I still think it is better to disable the module on uninstall, and
> enable the module on install.
>
Hi Scot,
have you also read the commit log?
- Fix leftover httpd.conf for AP_GEN_PLIST using ports. The problem is that
apxs does not remove module line from httpd.conf, it merely comments it out.
Later, on Apache deinstall, the file differs from stock httpd.conf and is not
deleted.
The issue is the following.
In case the LoadModule line is not removed from httpd.conf the port will be marked as broken by the ports build system.
I'm thinking about an parameter which change the semantic in bsd.apache.mk so the module can be installed enabled.
For example the following will do that (quick hack)
Index: bsd.apache.mk
===================================================================
--- bsd.apache.mk (revision 309921)
+++ bsd.apache.mk (working copy)
@@ -455,7 +445,11 @@
# apache22
@${ECHO} "@unexec ${SED} -i '' -E '/LoadModule[[:blank:]]+%%AP_NAME%%_module/d' %D/%%APACHEETCDIR%%/httpd.conf" >> ${PLIST}
@${ECHO} "%%APACHEMODDIR%%/%%AP_MODULE%%" >> ${PLIST}
+.if defined(AP_MODENABLE)
+ @${ECHO} "@exec %D/sbin/apxs -e -a -n %%AP_NAME%% %D/%F" >> ${PLIST}
+.else
@${ECHO} "@exec %D/sbin/apxs -e -A -n %%AP_NAME%% %D/%F" >> ${PLIST}
+.endif
@${ECHO} "@unexec echo \"Don't forget to remove all ${MODULENAME}-related directives in your httpd.conf\"">> ${PLIST}
. endif
.else
--
Regards,
olli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50E6A021.9000203>