Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 9 Apr 2013 20:59:50 +0200
From:      Michael Gmelin <freebsd@grem.de>
To:        freebsd-ports@freebsd.org
Cc:        Chris Rees <utisoft@gmail.com>
Subject:   Re: www/nginx pkg-plist + pkgng (detectable?)
Message-ID:  <20130409205950.677a6812@bsd64.grem.de>
In-Reply-To: <CADLo838OFhmA6AQNuHPjP=Kfw9Co9vWh3XqxrFkEH-dgb81pzA@mail.gmail.com>
References:  <20130330034028.0f8cefc8@bsd64.grem.de> <5156C0D9.50909@FreeBSD.org> <20130330142320.38010126@bsd64.grem.de> <20130408103118.67ea695a@bsd64.grem.de> <CADLo838OFhmA6AQNuHPjP=Kfw9Co9vWh3XqxrFkEH-dgb81pzA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 9 Apr 2013 19:43:15 +0100
Chris Rees <utisoft@gmail.com> wrote:


> 
> No, it's a bug in pkgng; it should respect @cwd.
> 

pkg should respect @cwd for sure, but looking at nginx's plist I think
that it should use the cwd marker consistently, so right now it says:

%%WWWDATA%%@exec mkdir -p -m 755 www/nginx-dist
%%WWWDATA%%@exec if [ ! -d %D/www/nginx/ ] ; then ln -fs
%D/www/nginx-dist %D/www/nginx; fi
%%WWWDATA%%www/nginx-dist/EXAMPLE_DIRECTORY-DONT_ADD_OR_TOUCH_ANYTHING
%%WWWDATA%%www/nginx-dist/index.html %%WWWDATA%%www/nginx-dist/50x.html
%%WWWDATA%%@exec chmod a-w www/nginx-dist
%%WWWDATA%%@unexec if [ -L %D/www/nginx ]; then rm -f %D/www/nginx; fi
%%WWWDATA%%@dirrmtry www/nginx-dist

IMHO this should be:

%%WWWDATA%%@exec mkdir -p -m 755 %D/www/nginx-dist
%%WWWDATA%%@exec if [ ! -d %D/www/nginx/ ] ; then ln -fs
%D/www/nginx-dist %D/www/nginx; fi
%%WWWDATA%%www/nginx-dist/EXAMPLE_DIRECTORY-DONT_ADD_OR_TOUCH_ANYTHING
%%WWWDATA%%www/nginx-dist/index.html %%WWWDATA%%www/nginx-dist/50x.html
%%WWWDATA%%@exec chmod a-w www/nginx-dist
%%WWWDATA%%@unexec if [ -L %D/www/nginx ]; then rm -f %D/www/nginx; fi
%%WWWDATA%%@dirrmtry %D/www/nginx-dist

Cheers,

-- 
Michael Gmelin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130409205950.677a6812>