Date: Mon, 02 Nov 2020 07:59:55 +0100 From: Antonin Houska <ah@melesmeles.cz> To: Mitchell Horne <mhorne@freebsd.org> Cc: Kristof Provost <kp@freebsd.org>, freebsd-riscv <freebsd-riscv@freebsd.org> Subject: Re: locore.S - two cosmetic changes Message-ID: <82965.1604300395@antos> In-Reply-To: <CADeAsy19Hqz-beSV7qhTiuH71X1ONdt7%2Bfm5oSzL1WK2AX=T0A@mail.gmail.com> References: <65290.1603693402@antos> <A3C334EB-B040-4345-956E-070E60FDEA5E@FreeBSD.org> <78054.1604073770@antos> <CADeAsy19Hqz-beSV7qhTiuH71X1ONdt7%2Bfm5oSzL1WK2AX=T0A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Mitchell Horne <mhorne@freebsd.org> wrote: > In short, the code is correct, but confusing. I have some in-progress > work that moves this logic out of locore.S, with the aim of making > this process a little easier to understand. Perhaps it's time I tried > to finish it :) > > Please send me a follow-up if you have more questions, and I'll do my > best to answer. ok, I think I understand now. I consider insufficient comments to be the problem here, but if you're going to rework this part, there's no reason to add comments to the existing code. Thanks for explanation. -- Antonín Houska www.melesmeles.cz
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?82965.1604300395>