Date: Sat, 15 Jul 2023 20:13:00 -0500 From: Matthew Grooms <mgrooms@shrew.net> To: virtualization@freebsd.org Subject: Re: BHYVE SNAPSHOT image format proposal Message-ID: <d8bf3e94-fe71-6070-1a94-5012e7718a82@shrew.net> In-Reply-To: <CAF3%2Bn_cPr0=Z-KbN9R6BqxhcQrhckUqtoqg7LN=dUowAr64sRg@mail.gmail.com> References: <67FDC8A8-86A6-4AE4-85F0-FF7BEF9F2F06@gmail.com> <6b98da58a5bd8e83bc466efa20b5a900298210aa.camel@FreeBSD.org> <8387AC83-6667-48E5-A3FA-11475EA96A5F@gmail.com> <d92db9bfbea181d6eb9d57b579d67e8e118ef4de.camel@FreeBSD.org> <986A83D8-E0E0-4030-9369-A5B3500E27C6@gmail.com> <79fabe94-b800-c713-48ea-518da1f74e4d@shrew.net> <CAF3%2Bn_cc5ZpGsKCff%2Bu-rSjnJn%2BN1jdu9KW0Y5b6n_TieMsfng@mail.gmail.com> <3973013d-c183-360f-d7ca-ca822859c23d@shrew.net> <CAF3%2Bn_czuJ=B2mok2wh7OPvkzMz7%2B9KRG8_NuCyEL9SMFLt6tw@mail.gmail.com> <3a037482-2e6c-667f-1979-d5b612e506ec@shrew.net> <CAF3%2Bn_cPr0=Z-KbN9R6BqxhcQrhckUqtoqg7LN=dUowAr64sRg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/15/23 12:31, Rob Wing wrote: > > On Saturday, July 15, 2023, Matthew Grooms <mgrooms@shrew.net > <mailto:mgrooms@shrew.net>> wrote: > > > We'll overlook the fact that it does attempt to consolidate files ( > 2 vs 3 ) and that there's no feedback requesting further > consolidation after being open for two years, but noted. > > You may as well abandon https://reviews.freebsd.org/D29262 > <https://reviews.freebsd.org/D29262>, for these reasons alone: > Thanks for the feedback. In the future, please feel free to add your concerns to the code review. It would be extremely helpful. > - JSON doesn't support storing binary data I don't know how to state it more clearly: Making binary copies of the data structures is the problem. Something tells me that you'll continue to ignore this, so I'll stop saying it. > - a snapshot should be contained in a single file Heard. A single file. > > The UPB patch addresses the above. Vitaliy's patch does nothing to > address any of it. If one is going to be proposed as an alternative > to the other, it better solve the same problems as then some. > > The UBP patch is not an alternative - show me another hypervisor that > uses JSON as their snapshot format. > Heard. JSON is bad. > The silence is real. > > > No, it's not. I've given you feedback multiple times. I'm very aware. The silence I was referring to wasn't yours. Feel free to re-read for context. Rob, I'm not hear to argue with you. I've shared all the opinions I feel are relevant to the file format proposal and would prefer not to waste the list's time. Thanks, -Matthew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d8bf3e94-fe71-6070-1a94-5012e7718a82>