Date: Sun, 27 Oct 2013 11:38:21 -0400 From: Sean Bruno <sean_bruno@yahoo.com> To: Eitan Adler <lists@eitanadler.com> Cc: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org> Subject: Re: [PATCH] contrib/groff Queisce -Wdangling else Message-ID: <1382888301.4717.4.camel@localhost> In-Reply-To: <CAF6rxg=GRnNHf-APiumRRdH5smbNk=C%2BvrxyFSdQEPnfw5fKzg@mail.gmail.com> References: <1382799852.32760.2.camel@localhost> <CAF6rxg=GRnNHf-APiumRRdH5smbNk=C%2BvrxyFSdQEPnfw5fKzg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-ZNbtej2iHF4DLutZa7Mt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Sat, 2013-10-26 at 20:22 -0400, Eitan Adler wrote: > On Sat, Oct 26, 2013 at 11:04 AM, Sean Bruno <sean_bruno@yahoo.com> wrote= : > > This adds proper braces to clear Clang warnings about dangling else > > statements in groff. There is no(intended) functional change. >=20 >=20 > For contributed code why not just disable warnings? Fixing code is > good but doing so in our repository instead of upstream doesn't help > as much. >=20 >=20 I believe very strongly that the people who construct compilers know C/C ++ far better than I do, so warnings are their note to me that I'm doing it wrong. Disabling warnings is global for a section of the tree (e.g. groff/roff). I can't (easily) isolate the warnings individually, so modifications to the code after I disable the warnings will get excluded as well, effectively opening the project to crappy code that breaks things (if the warnings are causing bugs). For this specific code (groff), it switched to gpl v3 in 2009, so we won't be doing any more code drops into our tree: Revision 1.5 - (view) (download) (annotate) - [select for diffs]=20 Sun Jan 4 14:50:51 2009 UTC (4 years, 9 months ago) by wl=20 Branch: MAIN=20 Changes since 1.4: +3 -3 lines=20 Diff to previous 1.4=20 * */*: Update GPL2 to GPL3. Therefore, if someone isn't going to rewrite the implementations, its up to us to maintain the code we have. sean "Warnings are meaningful." FreeBSD Clusteradm/Developer --=-ZNbtej2iHF4DLutZa7Mt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iQEcBAABAgAGBQJSbTNkAAoJEBkJRdwI6BaHyOUH/126jddDrGoa1pZBLYDzqiv4 kUy6zoycgrrFL7n+/moBK7IqAu8vA4VIRJfn5G+ThN6Z2z5xPBM5YHx7hPK0XXpG VyzWycmYRlUBDBJF7NNz+VfB+Kjwm29n3JoEgp2sfHIvxufIsOxrVAKwbRrQ0qbK kYXEcejKPOhgP8v1cwYFQjZW58b6yDSDkreoESE1DuVyUd8K7b4bey9rMMa9Jclo 9LNzthocbDhd2k8lazzl6UZBbWRo5Egv5qwN9K7heOjXfymAolzCy2NU3Mo28OxO owHumYubTuKaJYdyb03fifWKVxrcqk+SCBFhTsyb6lo41nKy5XjRzzM61YYvvn4= =2//t -----END PGP SIGNATURE----- --=-ZNbtej2iHF4DLutZa7Mt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1382888301.4717.4.camel>