Date: Sun, 25 Aug 2013 08:39:31 +0200 From: Jeremie Le Hen <jlh@FreeBSD.org> To: Eitan Adler <lists@eitanadler.com> Cc: FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: weekly periodic security status Message-ID: <20130825063931.GH24767@caravan.chchile.org> In-Reply-To: <CAF6rxgkyw28xibzpAkGxj9O9HHHikW=zfwNHh7nn6bXJ6xn8gg@mail.gmail.com> References: <20130822204958.GC24767@caravan.chchile.org> <CAF6rxg=hfT829b0yNc5YObnz6U4%2B3afuEPR3JZK9nvXophCtvg@mail.gmail.com> <20130824204725.GF24767@caravan.chchile.org> <CAF6rxgkyw28xibzpAkGxj9O9HHHikW=zfwNHh7nn6bXJ6xn8gg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 24, 2013 at 06:03:37PM -0400, Eitan Adler wrote: > On Sat, Aug 24, 2013 at 4:47 PM, Jeremie Le Hen <jlh@freebsd.org> wrote: > > On Sat, Aug 24, 2013 at 10:41:56AM -0400, Eitan Adler wrote: > >> On Thu, Aug 22, 2013 at 4:49 PM, Jeremie Le Hen <jlh@freebsd.org> wrote: > >> > Well, whatever, if you have any concerns, objections or comments, please > >> > speak now :). > >> > >> This LGTM but please include a comment above the warning with a date / > >> release number when this compatibility can be removed. > > > > If the old variable names are deprecated in releng/10, they can be > > removed in releng/11, can't they? > > Yes, and this should be indicated in a comment. When I see > "deprecated" or "old hack" or similar terms in code it takes some > archaeology to figure out when it was added and when it could be > removed. It would be nice to help the future reader a bit. The purpose of my question was to know what to put in the comment ;-). Thanks for pointing this out. -- Jeremie Le Hen Scientists say the world is made up of Protons, Neutrons and Electrons. They forgot to mention Morons.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130825063931.GH24767>