Date: Fri, 29 Dec 2023 12:30:32 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: tuexen@freebsd.org Cc: FreeBSD CURRENT <freebsd-current@freebsd.org> Subject: Re: devel/nspr: Fails to build on 1500008 5f71f9636efa Message-ID: <CAFDf7ULcNYuD4ZAWXCjgbcWBbdmWw2b0O1vb9phqjXCP5VhpJA@mail.gmail.com> In-Reply-To: <CAFDf7UJBY9a=SX_iTE2TOxK_r%2BaK1NDizMdebuYeaL6Zb89QbQ@mail.gmail.com> References: <CAFDf7U%2BxbTuhS7nUzeZgVknMPyyfYxuakFtrE4=h-1LtFK_Yig@mail.gmail.com> <9EE91B0D-6CFB-464E-AB9C-3A15D77D55FB@freebsd.org> <CAFDf7UJBY9a=SX_iTE2TOxK_r%2BaK1NDizMdebuYeaL6Zb89QbQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] (...) -ansi == Same as -std=c89 So it seems correct to remove it when -std=c99 is used. Nuno Teixeira <eduardo@freebsd.org> escreveu no dia sexta, 29/12/2023 à(s) 12:03: > > > > I think we have two options: >> 1. Build the ports with a C version of at least C99. >> > > - Adding USE_CSTD=c99 > - Removing -ansi: > --- configure.orig 2023-12-29 11:54:11 UTC > +++ configure > - CFLAGS="$CFLAGS $(DSO_CFLAGS) -ansi -Wall" > + CFLAGS="$CFLAGS $(DSO_CFLAGS) -Wall" > > Fix build. > > Notes: > > Adding USE_CSTD=c99 doesn't fix build by itself like we seen on some ports > that were fixed by it. > > Something have changed from current 1500007 to 1500008. > > > >> 2. Remove the inline from tcp_[gs]et_flags(). >> >> Best regards >> Michael >> > -- >> > Nuno Teixeira >> > FreeBSD Committer (ports) >> >> > > -- > Nuno Teixeira > FreeBSD Committer (ports) > -- Nuno Teixeira FreeBSD Committer (ports) [-- Attachment #2 --] <div dir="ltr"><div>(...)</div><div>-ansi == Same as -std=c89</div><div><br></div><div>So it seems correct to remove it when -std=c99 is used.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Nuno Teixeira <<a href="mailto:eduardo@freebsd.org">eduardo@freebsd.org</a>> escreveu no dia sexta, 29/12/2023 à(s) 12:03:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> I think we have two options:<br> 1. Build the ports with a C version of at least C99.<br></blockquote><div><br></div><div>- Adding USE_CSTD=c99</div><div>- Removing -ansi:<br>--- configure.orig 2023-12-29 11:54:11 UTC<br>+++ configure<br>- CFLAGS="$CFLAGS $(DSO_CFLAGS) -ansi -Wall"<br>+ CFLAGS="$CFLAGS $(DSO_CFLAGS) -Wall"</div><div><br></div><div>Fix build.</div><div><br></div><div>Notes:</div><div><br></div><div>Adding USE_CSTD=c99 doesn't fix build by itself like we seen on some ports that were fixed by it.<br></div><div><br></div><div>Something have changed from current 1500007 to 1500008.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> 2. Remove the inline from tcp_[gs]et_flags().<br> <br> Best regards<br> Michael<br> > -- <br> > Nuno Teixeira<br> > FreeBSD Committer (ports)<br> <br> </blockquote></div><br clear="all"><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><span style="color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committer (ports)</span></div></div></div> </blockquote></div><br clear="all"><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><span style="color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committer (ports)</span></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7ULcNYuD4ZAWXCjgbcWBbdmWw2b0O1vb9phqjXCP5VhpJA>