Date: Fri, 11 Nov 2011 13:53:45 +0800 From: Paul Ambrose <ambrosehua@gmail.com> To: Ryan Stone <rysto32@gmail.com> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: [PATCH] Fix types of arguments to dtrace syscall return probes Message-ID: <CAMwoQQ6J=Sqy_Y4C17-mZVWU9_zxNy41GSCSbw8P8is85q3AdQ@mail.gmail.com> In-Reply-To: <CAFMmRNyT9W2QnPBbGoZzeoQzvR%2Bv_GkTETM9Sk3ks1yVkRJyKg@mail.gmail.com> References: <CAFMmRNzpj8hGG5YWsKTmcRuphw37eUr6bcDTn6-bBWKOOcQGmQ@mail.gmail.com> <CAMwoQQ4c0XHf1kX9uXk5KOD-nRZezOW%2BB2cB03gUO9g2j32Hfg@mail.gmail.com> <CAFMmRNyT9W2QnPBbGoZzeoQzvR%2Bv_GkTETM9Sk3ks1yVkRJyKg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
If there is anything I can do for kern/160307 or other Dtrace issue ,
please let me know
2011/11/8 Ryan Stone <rysto32@gmail.com>:
> On Mon, Nov 7, 2011 at 9:16 AM, Paul Ambrose <ambrosehua@gmail.com> wrote=
:
>> diff --git a/sys/kern/kern_ctf.c b/sys/kern/kern_ctf.c
>> index bdff96e..2737860 100644
>> --- a/sys/kern/kern_ctf.c
>> +++ b/sys/kern/kern_ctf.c
>> @@ -90,7 +90,7 @@ link_elf_ctf_get(linker_file_t lf, linker_ctf_t *lc)
>> =A0 =A0 =A0 =A0 * ctfcnt to -1. See below.
>> =A0 =A0 =A0 =A0 */
>> =A0 =A0 =A0 =A0if (ef->ctfcnt < 0)
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 return (0);
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 return (EFTYPE);
>>
>> =A0 =A0 =A0 =A0/* Now check if we've already loaded the CTF data.. */
>> =A0 =A0 =A0 =A0if (ef->ctfcnt > 0) {
>> ------------------------------------------------------------------------=
---------------
>
> I have committed this as r227342. =A0Thanks for the fix.
>
>> And I post another fix for the ${NORMAL_CTFCONVERT} issue, could you
>> check it for me?
>
> Yes, I can take a look.
>
>> =A0kern/160307, I check the /boot/kernel/kernel with ctfdump, and found
>> the kernel image has right ctf information, do you
>> have any idea?
>
> Offhand, no. =A0I'll try to find some time to look at your PRs.
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMwoQQ6J=Sqy_Y4C17-mZVWU9_zxNy41GSCSbw8P8is85q3AdQ>