Date: Wed, 06 May 2015 14:33:44 -0400 From: John Baldwin <jhb@freebsd.org> To: Ryan Stone <rysto32@gmail.com> Cc: FreeBSD Current <freebsd-current@freebsd.org>, Eric Badger <eric_badger@dell.com>, "current@freebsd.org" <current@freebsd.org> Subject: Re: PCI PF memory decode disable when sizing VF BARs Message-ID: <2106775.8KnH0oLhUZ@ralph.baldwin.cx> In-Reply-To: <CAFMmRNyUiet0O2WXBv1K%2BTF=qtQT7Tdwf4npcCNKZiF4SZVh8w@mail.gmail.com> References: <cb2ce4e0ff294bcd982c6db87ae64dfb@mspexmb1.Beer.Town> <11092809.7nmbPfKl0V@ralph.baldwin.cx> <CAFMmRNyUiet0O2WXBv1K%2BTF=qtQT7Tdwf4npcCNKZiF4SZVh8w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, May 06, 2015 02:24:24 PM Ryan Stone wrote: > On Wed, May 6, 2015 at 11:45 AM, John Baldwin <jhb@freebsd.org> wrote: > > > There are some devices with BARs in non-standard locations. :( If there is > > a flag to just disable the VF bar decoding, then ideally we should just be > > doing that and leaving the global decoding flag alone while sizing the VF > > BAR. > > > > Disabling SR-IOV BAR decoding in this function is currently redundant, as > it's already done in pci_iov.c, but I guess to keep the interface sane it > makes sense to do it here too. Something like this then? Ah, sorry, I didn't know you did it in the caller already. Perhaps then something more like your previous patch, but using the test you added here (PCIR_IS_IOV) instead of your previous check against BAR values to decide when to frob the command register? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2106775.8KnH0oLhUZ>