Date: Mon, 3 Mar 2014 10:31:35 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Julio Merino <jmmv@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Giorgos Keramidas <keramida@freebsd.org> Subject: Re: [PATCH v2] convert bin/date over to ATF Message-ID: <CAGHfRMCASnNx2t9MiAQ5cSWR0R7wuswMnZ0J1Hpo7WjoUdvbrA@mail.gmail.com> In-Reply-To: <CAFY7cWBHaftY=LOen=_gescMkoyCoKU69HRyqOfW10YAZ2OzuQ@mail.gmail.com> References: <6079AD8F-5EBB-431C-A06B-9B51E2729F5A@gmail.com> <B90AA730-B7B8-4F1A-9D07-67861C9A6401@meroh.net> <FA467521-BB53-47C0-BAE1-8BCAE29F922F@gmail.com> <CADyfeQXG6KGwgT1X90Ymr%2BFYnwL74H_G2zBvkgdzEhPospNM8A@mail.gmail.com> <4A25ADF9-3714-4006-ACB6-F8C745CB38AE@gmail.com> <CAFY7cWBHaftY=LOen=_gescMkoyCoKU69HRyqOfW10YAZ2OzuQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 2, 2014 at 1:22 PM, Julio Merino <jmmv@freebsd.org> wrote: > On Mon, Jan 27, 2014 at 5:03 AM, Garrett Cooper <yaneurabeya@gmail.com> wrote: >> The attached patch incorporates the input from Julio for converting bin/date/tests over to ATF. > > Apologies for the delay here as well... > > Pretty much all style nits: > > * This file is full of boilerplate and it's really hard to actually > see the tests. I think this would benefit from a simple helper > function that calls atf_test_case and evals the tiny body() with the > call to check. Ok. > * I'd get rid of the descr definitions; they provide no value. Ok. > * I'd also get rid of all the horizontal dividing lines. If you make > the test case definitions compact, they just serve to increase the > file length. Ok. > * Remove the TZ and LC_ALL overrides. This is a given within ATF. Ok. > * Why "format_string_functional_test"? I'd just call it "format_string_test". I guess I could... > * I don't think the # vim trailing line belongs in the tree. Ok. -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMCASnNx2t9MiAQ5cSWR0R7wuswMnZ0J1Hpo7WjoUdvbrA>