Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Aug 2013 12:57:09 +0900 (JST)
From:      YAMAMOTO Shigeru <shigeru@iij.ad.jp>
To:        rodrigc@FreeBSD.org
Cc:        freebsd-current@freebsd.org
Subject:   Re: quick hack to support "option VIMAGE" on USB Ethernet
Message-ID:  <20130813.125709.1168850046133874829.shigeru@iij.ad.jp>
In-Reply-To: <CAG=rPVcK-pfELCeUhK=EoShvZRsJaBzfW_4w_qM_=npi9zEoMg@mail.gmail.com>
References:  <20130812.124834.1287983109881683567.shigeru@iij.ad.jp> <CAG=rPVcK-pfELCeUhK=EoShvZRsJaBzfW_4w_qM_=npi9zEoMg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

Hi all,

From: Craig Rodrigues <rodrigc@FreeBSD.org>
Subject: Re: quick hack to support "option VIMAGE" on USB Ethernet
Date: Mon, 12 Aug 2013 17:52:39 -0700
> I do not have a USB Ethernet device, and do not fully understand VIMAGE yet.
> Is your patch still necessary in CURRENT, after this patch was applied to
> subr_bus.c?
> 
> http://lists.freebsd.org/pipermail/svn-src-all/2013-July/071878.html

I make a patch for r254236@HEAD which is newer than r253346.

My try is,
1) I try to enable "option VIMAGE" at r254236@HEAD.
It causes panic at accessing V_if_index in ifindex_alloc_locked().

2) I try to protect if_alloc(IFT_ETHER) at ue_attach_post_task() using
 CURVNET_SET_QUIET(curvnet) and CURVNET_RESTORE().
It causes abort at CURVNET_SET_QUIET() becasue curvnet is NULL.

3) I create my patch.
It is saving curvnet at uether_ifattach() and using saved curvnet at calling
CURVNET_SET_QUIET().
It seems me work.

Thanks,
-------
YAMAMOTO Shigeru <shigeru@iij.ad.jp>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130813.125709.1168850046133874829.shigeru>