Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 May 2012 07:41:13 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Garrett Cooper <yanegomi@gmail.com>
Cc:        Kevin Lo <kevlo@FreeBSD.org>, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Baptiste Daroussin <baptiste.daroussin@gmail.com>
Subject:   Re: svn commit: r235771 - head/bin/expr
Message-ID:  <20120522054113.GL63744@ithaqua.etoilebsd.net>
In-Reply-To: <CAGH67wR9OCq93bWCfJPn6WXNFfVUthBrUhtxpHDRVQXWavx9yg@mail.gmail.com>
References:  <201205220301.q4M31tJn084097@svn.freebsd.org> <CAGH67wR9OCq93bWCfJPn6WXNFfVUthBrUhtxpHDRVQXWavx9yg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--jtcAeju3WzRmRF+o
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 21, 2012 at 09:20:59PM -0700, Garrett Cooper wrote:
> On Mon, May 21, 2012 at 8:01 PM, Kevin Lo <kevlo@freebsd.org> wrote:
> > Author: kevlo
> > Date: Tue May 22 03:01:54 2012
> > New Revision: 235771
> > URL: http://svn.freebsd.org/changeset/base/235771
> >
> > Log:
> > =A0Remove redundant declaration of yyparse
> >
> > =A0Reported by: =A0tinderbox
> >
> > Modified:
> > =A0head/bin/expr/expr.y
> >
> > Modified: head/bin/expr/expr.y
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/bin/expr/expr.y =A0 =A0 =A0 =A0Tue May 22 02:37:04 2012 =A0 =
=A0 =A0 =A0(r235770)
> > +++ head/bin/expr/expr.y =A0 =A0 =A0 =A0Tue May 22 03:01:54 2012 =A0 =
=A0 =A0 =A0(r235771)
> > @@ -74,7 +74,6 @@ int =A0 =A0 =A0 =A0 =A0 to_integer(struct val *);
> > =A0void =A0 =A0 =A0 =A0 =A0 to_string(struct val *);
> > =A0int =A0 =A0 =A0 =A0 =A0 =A0yyerror(const char *);
> > =A0int =A0 =A0 =A0 =A0 =A0 =A0yylex(void);
> > -int =A0 =A0 =A0 =A0 =A0 =A0yyparse(void);
> >
> > =A0%}
>=20
>     There are a lot more than just this unfortunately (I'm working on
> a complete patchset).
>     This breakage really makes me think that yacc isn't being built at
> the right time or pathed properly in the build system.
> Thanks,
> -Garrett
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"

The complete patch set is there:
http://people.freebsd.org/~bapt/fix-after-yacc.diff
(clang seems to not detect those redudant warning, while gcc complains)

I'm waiting for review before committing)

Thanks for this fix I'll remove it from my patchset

regards,
Bapt

--jtcAeju3WzRmRF+o
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAk+7JvkACgkQ8kTtMUmk6EwpoQCeJL4vVemxrnkPQBWhYc2QEWRS
F7kAnjADiwzOot/aj41BuamAe1WRtd6R
=eA8L
-----END PGP SIGNATURE-----

--jtcAeju3WzRmRF+o--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120522054113.GL63744>