Date: Tue, 7 Feb 2023 17:27:17 -0700 From: Warner Losh <imp@bsdimp.com> To: Mateusz Guzik <mjguzik@gmail.com> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: buildkernel avoidably building modules specified in the config Message-ID: <CANCZdfrJK8_kXSHD_FvOAmAxJ55QBZk36v88rS%2BojS=dhSHdtA@mail.gmail.com> In-Reply-To: <CAGudoHETEb=tBAEL61MS5=ugD0EMOmxCVK23E2-CXbbfOEeWzg@mail.gmail.com> References: <CAGudoHETEb=tBAEL61MS5=ugD0EMOmxCVK23E2-CXbbfOEeWzg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000001cd5a105f425562b Content-Type: text/plain; charset="UTF-8" On Tue, Feb 7, 2023, 5:20 PM Mateusz Guzik <mjguzik@gmail.com> wrote: > ... then a lot of the code ends up being compiled twice for no good reason. > > This popped up again as clang 15 emits a ton of warnings vs K&R funcs. > > I don't know how this works internally, is it really a big problem to sort > out? > I figured config(8) could generate a bunch of WITHOUT_ of similar, but I > guess > sys/modules/Makefile will have to be patched to support it, which it > only does for some modules at the moment. > > I don't have any interest in working on it, so just bringing this up > for interested. > Yea... it's on the list that config.ng would do... At one point modules and kernel .o files were built differently which precluded a number of Makefile hacks. Warner Warner > --0000000000001cd5a105f425562b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Tue, Feb 7, 2023, 5:20 PM Mateusz Guzik <<a href= =3D"mailto:mjguzik@gmail.com">mjguzik@gmail.com</a>> wrote:<br></div><bl= ockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #= ccc solid;padding-left:1ex">... then a lot of the code ends up being compil= ed twice for no good reason.<br> <br> This popped up again as clang 15 emits a ton of warnings vs K&R funcs.<= br> <br> I don't know how this works internally, is it really a big problem to s= ort out?<br> I figured config(8) could generate a bunch of WITHOUT_ of similar, but I gu= ess<br> sys/modules/Makefile will have to be patched to support it, which it<br> only does for some modules at the moment.<br> <br> I don't have any interest in working on it, so just bringing this up<br= > for interested.<br></blockquote></div></div><div dir=3D"auto"><br></div><di= v dir=3D"auto">Yea... it's on the list that config.ng would do... At on= e point modules and kernel .o files were built differently which precluded = a number of Makefile hacks.=C2=A0 =C2=A0</div><div dir=3D"auto"><br></div><= div dir=3D"auto">Warner=C2=A0</div><div dir=3D"auto"><br></div><div dir=3D"= auto">Warner</div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote = class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid= ;padding-left:1ex"> </blockquote></div></div></div> --0000000000001cd5a105f425562b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrJK8_kXSHD_FvOAmAxJ55QBZk36v88rS%2BojS=dhSHdtA>