Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 8 Jun 2013 18:29:25 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        Adrian Chadd <adrian@freebsd.org>
Cc:        Ed Schouten <ed@80386.nl>, freebsd-mips@freebsd.org
Subject:   Re: svn commit: r251524 - in head/sys: conf mips/mips
Message-ID:  <EC455689-A1D1-49C6-8B87-3FB7F86FEE91@bsdimp.com>
In-Reply-To: <CAJ-Vmo=367OQfFpKP9ME%2BL9Yb7=B-RCdF_8=nj3_adDetpHfJQ@mail.gmail.com>
References:  <201306081319.r58DJBS0061186@svn.freebsd.org> <CAJ-Vmok3N2bgZzv5sphvdXUa4v2KDZ0NGr-cKObL1Y8m5%2BGn2Q@mail.gmail.com> <CAJOYFBCq9kDbt7srvEHZUJLPB_Vt9rFLhgDyuqMRha2R0K%2BPPA@mail.gmail.com> <CAJ-Vmo=367OQfFpKP9ME%2BL9Yb7=B-RCdF_8=nj3_adDetpHfJQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On Jun 8, 2013, at 3:57 PM, Adrian Chadd wrote:

> Hm,
>=20
> On 8 June 2013 10:35, Ed Schouten <ed@80386.nl> wrote:
>> Hello Adrian,
>>=20
>> 2013/6/8 Adrian Chadd <adrian@freebsd.org>:
>>> .. have we decided whether to nuke the NOP flush from orbit?
>>=20
>> I thought we didn't make a clear decision on that yet, so I decided =
to
>> leave it as it is for now. I'll make sure the sync routine in this
>> file remains in sync with the one in <machine/atomic.h>.
>=20
> Can we just commit bsdimp's change and have your macro include his
> "extra sync ops" macro, in case that running system requires it?

Well, the right kind of memory barrier should be used, and those should =
be defined in machine/cpufunc.h or somesuch.

Warner




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EC455689-A1D1-49C6-8B87-3FB7F86FEE91>