Date: Thu, 17 Dec 2015 14:10:39 +0100 From: Svatopluk Kraus <onwahe@gmail.com> To: Adrian Chadd <adrian@freebsd.org> Cc: "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org> Subject: Re: RFC: migrate arm/arm/intrng.c -> kern/subr_intr.c in prep for MIPS using it Message-ID: <CAFHCsPWwZZpLh2SupSNWH-m27Adg%2BFhVovJ=ixW-ANBYHnQAzA@mail.gmail.com> In-Reply-To: <CAJ-VmokNVAS2MEt70LDWbvRW2jS9XwbuRACHr1-=7PoP-sqLTQ@mail.gmail.com> References: <CAJ-VmokNVAS2MEt70LDWbvRW2jS9XwbuRACHr1-=7PoP-sqLTQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Just some suggestions about renaming. arm_irqsrc -> intr_src or intr_source ARM_ISRCT_xyz -> INTR_SRCT_xyz ARM_ISRCF_xyz -> INTR_SRCF_xyz ARM_ISRC_NAMELEN -> INTR_SRC_NAMELEN sys/arm/arm/machdep_intr.c ... remove unneeded headers? sys/conf/files.arm ... rename arm_intrng option And FYI, the framework needs some more love. Svata On Thu, Dec 17, 2015 at 9:07 AM, Adrian Chadd <adrian@freebsd.org> wrote: > Hi, > > kan@ has been working on bringing in support for the CI20 board - > where he used the arm intrng code in his mips port. > > So, I figured it is a good time to migrate the arm code into a generic > spot to be reused. > > Here's my initial port: > > http://people.freebsd.org/~adrian/arm/20151216-arm-intrng-generic-1.diff > > It: > > * moves the machdep bits into a separate file (arm/arm/machdep_intr.c); > * move intrng.c into sys/kern/subr_intr.c; > * rename the ARM_ -> INTR_, and arm_ -> intr_ symbols; > * fix up a variety of consumers of said code. > > It's a WIP - I plan on doing the minimum needed to put it there so we > can use the code for other ports, and not try to solve the "how do we > integrate this cleanly into the existing interrupt code" problem. > > This intr sharing code should make kan's job a lot easier. :) > > Thanks! > > > -a > _______________________________________________ > freebsd-arm@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFHCsPWwZZpLh2SupSNWH-m27Adg%2BFhVovJ=ixW-ANBYHnQAzA>