Date: Thu, 10 Nov 2011 09:15:14 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Doug Barton <dougb@freebsd.org> Cc: current@freebsd.org Subject: Re: [head tinderbox] failure on i386/i386 Message-ID: <CAJ-Vmo=UEoGZ4Nvdwe8=tLw4P4tr20h3YFN7ga8-XBpUNMq4hw@mail.gmail.com> In-Reply-To: <CAJ-VmomakUnr-GvgHkSHnQzDCGCdqPQ6k6cJfMiSYTn6mBnVHw@mail.gmail.com> References: <201111100705.pAA75eIT023291@freebsd-current.sentex.ca> <4EBB7A0A.20700@FreeBSD.org> <CAJ-Vmokkwge%2Bu7BAJhq9Gu0Wqp0afuEPM2s1zPtmVqkFzFPr1Q@mail.gmail.com> <CAJ-VmomakUnr-GvgHkSHnQzDCGCdqPQ6k6cJfMiSYTn6mBnVHw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, The problem right now is that when the code is compiled as a module, it sucks in -all- of the chipset support rather than only a subset. So there are two problems: * AH_SUPPORT_AR5416 is still needed to build the driver and HAL, and * the module builds all chipset support, whether or not AH_SUPPORT_AR5416 is defined. I notice that some modules do check whether VIMAGE is defined (.if defined(VIMAGE)) - is there some equally evil way that I can propagate some build time options to the module build to specify which modules are built, based on the existance or not of AH_SUPPORT_AR5416? (It gets messier, as at least two wireless SoC modules just don't need to be built unless the user definitely wants them to be.) I still think the correct thing to do at the present time is to explicitly not build the ath modules unless the architecture can use it, and if it can use it, build them with explicit net80211/ath configuration. Otherwise you end up with modules/kernel being out of sync in terms of configuration. For example, a user reported (and this is why I "fixed" sys/modules/ath/Makefile) that they had added ATH_DEBUG and AH_DEBUG - but because the Makefile overrides opt_ah.h regardless of whether it exists or not, it didn't include the debugging code. Similar hilarity occurs with/without IEEE80211_TDMA and IEEE80211_DEBUG for example. Thanks, Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=UEoGZ4Nvdwe8=tLw4P4tr20h3YFN7ga8-XBpUNMq4hw>