Date: Wed, 27 Jan 2021 12:20:30 -0700 From: Warner Losh <imp@bsdimp.com> To: Li-Wen Hsu <lwhsu@freebsd.org> Cc: Ian Lepore <ian@freebsd.org>, "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: Change in the uname Message-ID: <CANCZdfoZustEL6Rx5cGH6eyAb=fuKoHZt%2Bd8z1_e%2Borqz_EaOg@mail.gmail.com> In-Reply-To: <CAKBkRUwGQr9MWUFPiSF8dv4wMiADTKyMRRv9U-aoNcY2T-Jpig@mail.gmail.com> References: <CANCZdfqYhdgbPiMc41hSoBoPNVMwJbp%2Bks5Jxic-fAAN=d8Cqg@mail.gmail.com> <10fec1da415cd8d3c080a2173b9245ff35fceac8.camel@freebsd.org> <CAKBkRUwGQr9MWUFPiSF8dv4wMiADTKyMRRv9U-aoNcY2T-Jpig@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 25, 2021 at 3:03 PM Li-Wen Hsu <lwhsu@freebsd.org> wrote: > On Tue, Jan 26, 2021 at 5:04 AM Ian Lepore <ian@freebsd.org> wrote: > > That all sounds good, except the 'v' is a bit odd, normally it implies > > a "version" number, which isn't exactly what this is. How about 'n' or > > '#' since it's just a count? > > Seconded, sorry for discussing the color of bikeshed, but 'v' is also > not intuitive to me. Since it is still a counter, and we are removing > the 'g' in the second part, cXXXXX-HASH is still distinguishable with > the old cXXXXX-gHASH. > > Or, maybe call it gXXXXX-HASH which stands for git commit count XXXXX, > with hash value HASH? > I can do 'n' instead of 'v'. I think that 'g' would be a bit confusing since the connection to git is less obvious. I happen to like the 'old school' versioning that would do X.Y(Z) where Z is a count of changes (whatever that means) (either since X.0 started or back to the start of the thing). That would be branch(version)-hash. I opted to not implement that, though. While I like it, I know I'm old school and this style has fallen out of fashion since the 80s and 90s when it was popular on the 'big iron' (TOPS-20, IBM, etc) as the 'big iron' culture has given way to other schools of thought. It's also harder to script parse and harder to implement. All in all, I think 'v' or 'n' is best and most clear. # I'd like to avoid because in the non-reproducible build case #x is the build number. Any last comments before I roll this in later today to hit the MFC window? Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoZustEL6Rx5cGH6eyAb=fuKoHZt%2Bd8z1_e%2Borqz_EaOg>