Date: Sat, 07 Jul 2012 18:30:31 +0400 From: Boris Samorodov <bsam@passap.ru> To: Vitaly Magerya <vmagerya@gmail.com> Cc: ports@freebsd.org Subject: Re: USE_GMAKE fails in QATty? Message-ID: <4FF84807.2060600@passap.ru> In-Reply-To: <CAL409KxofhFEN1F=Pa%2BFCpJ812djrNqJcBpNHpfvj0EYWLWHng@mail.gmail.com> References: <CAL409Kwcx8YcZFoKjrWP8axiX_gfW%2BS%2By2Rb=pp8HRbtPwoqSw@mail.gmail.com> <4FF82A59.7030201@passap.ru> <CAL409KxofhFEN1F=Pa%2BFCpJ812djrNqJcBpNHpfvj0EYWLWHng@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
07.07.2012 18:13, Vitaly Magerya пишет: > On 07/07/2012, Boris Samorodov <bsam@passap.ru> wrote: >> Seems that Mk/bsd.port.mk assumes that LOCALBASE for gmake >> is always /usr/local. Please, try the following patch. >> >> --- bsd.port.mk 1 Jul 2012 20:57:48 -0000 1.732 >> +++ bsd.port.mk 7 Jul 2012 12:20:17 -0000 >> @@ -1647,7 +1647,7 @@ >> EXTRACT_DEPENDS+= unmakeself:${PORTSDIR}/archivers/unmakeself >> .endif >> .if defined(USE_GMAKE) >> -BUILD_DEPENDS+= gmake:${PORTSDIR}/devel/gmake >> +BUILD_DEPENDS+= ${LOCALBASE}/bin/gmake:${PORTSDIR}/devel/gmake >> CONFIGURE_ENV+= MAKE=${GMAKE} >> .endif > > It helps partially: gmake is correctly recognized as installed, > but building ports with it still does not work since GMAKE is > still "gmake". This is additionally needed: > > --- bsd.commands.mk.orig 2012-07-07 16:59:52.000000000 +0300 > +++ bsd.commands.mk 2012-07-07 16:59:44.000000000 +0300 > @@ -43,7 +43,7 @@ > FIND?= /usr/bin/find > FLEX?= /usr/bin/flex > FMT?= /usr/bin/fmt > -GMAKE?= gmake > +GMAKE?= ${LOCALBASE}/bin/gmake > GREP?= /usr/bin/grep > GUNZIP_CMD?= /usr/bin/gunzip -f > GZCAT?= /usr/bin/gzcat Yes, this is the right fix. I've overlooked this. > The problem comes down to the fact that redports/QATty changes > LOCALBASE, but does not put it into PATH. Are ports are supposed > to work without $LOCALBASE/bin in PATH? Maybe it's just a glitch > in redports setup? All ports should support non standard LOCALBASE. Please, submit a PR on the case with both patches and ask to assign to portmgr@. This change needs to be tested at an exp-run. -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FF84807.2060600>