Date: Mon, 17 Oct 2011 14:19:14 -0600 From: "Kenneth D. Merry" <ken@freebsd.org> To: Kevin Oberman <kob6558@gmail.com> Cc: ports@freebsd.org Subject: Re: audio/cdparanoia broken on -CURRENT, and probably on 9.0 Message-ID: <20111017201914.GA52299@nargothrond.kdm.org> In-Reply-To: <CAN6yY1u8=hMiKSH%2BSyq=rNoouFDZ0%2BwTz2_GxxkQAVTbbbnO-g@mail.gmail.com> References: <CAN6yY1vFXNRjGyA2NHtGcMhvgueRLvV=QeAYj6y1Qf1PjU1OrA@mail.gmail.com> <20111012033304.GA48367@nargothrond.kdm.org> <CAN6yY1s4%2B_qcJZVRE_ffcNq9NsjRJLchUXsiBNKgCu1DKm_4rA@mail.gmail.com> <CAN6yY1u8=hMiKSH%2BSyq=rNoouFDZ0%2BwTz2_GxxkQAVTbbbnO-g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 16, 2011 at 15:20:22 -0700, Kevin Oberman wrote: > On Tue, Oct 11, 2011 at 9:00 PM, Kevin Oberman <kob6558@gmail.com> wrote: > > On Tue, Oct 11, 2011 at 8:33 PM, Kenneth D. Merry <ken@freebsd.org> wrote: > >> On Tue, Oct 11, 2011 at 15:52:35 -0700, Kevin Oberman wrote: > >>> > On Fri, Oct 07, 2011 at 03:46:22 -0400, b. f. wrote: > >>> > > Just a note to say that recent changes on -CURRENT (r225950, meaning > >>> > > that it is probably broken on 9.0 after r226067) have broken > >>> > > audio/cdparanoia, and it should be fixed or marked as BROKEN there. ?I > >>> > > haven't filed a PR, or attempted to patch it yet -- I think that it > >>> > > would be worthwhile to look into moving to 10.2, which has a large > >>> > > number of improvements, although suffering from some Linuxisms. > >>> > > >>> > This will be easy to patch, using one of two methods: > >>> > > >>> > ?- change struct scsi_sense_data to struct scsi_sense_data_fixed > >>> > or, better yet: > >>> > ?- use scsi_extract_sense_len(), which will work for fixed or descriptor sense. > >>> > >>> Ken, > >>> > >>> OK. I have grepped through all of the cdparanoia sources and fine no > >>> instances of scsi_sense_data. Where in the heck do I find it so I can > >>> get this port built? 10.2 would be lovely, but I just need cdparanoia > >>> on 9-stable quickly and I fear that hte package will no longer work > >>> after r226067. > >> > >> There is no FreeBSD support in cdparanoia by default. ?It is patched in by > >> the ports system. > >> > >> Go into the directory for the port, do a 'make fetch' and then 'make patch'. > >> > >> Then go into cdparanoia-III-alpha9.8/interface and copy the attached file > >> on top of scsi_interface.c. > >> > >> I've checked that it compiles on a system running code before the change, > >> but I think that change should work for systems before or after the change. > >> > >> Let me know whether it works for you. > > > > Thanks so much! > > > > Yes, the new scsi_interface.c compiled cleanly and cdparanoia built > > and installed. > > > > I am in the process of re-building all ports after I upgraded my > > system to 9-stable, so I really can't plug in my CD and try ripping > > aomething right now, but I'll try soonand let you know how it worked. > > Finally got all of my ports installed and re-booted with the DVD > installed. Sorry to have taken so long, but rebuilding over 1600 ports > on an old, slow laptop takes a lot of time and I had to tweak several > port to get them to build. > > With the modified scsi_interface.c file you sent, cdparanoia seems to > be working just fine. > > Thanks! Great, glad to hear it! > Should I submit a PR with the new file? Yes. I'm not a ports committer, it would be better for one of them (ideally the mantainer, if any) to go in and fix it. Ken -- Kenneth Merry ken@FreeBSD.ORG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111017201914.GA52299>