Date: Wed, 22 Dec 2021 19:37:25 +0100 From: Gary Jennejohn <gljennjohn@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: WITHOUT_PF breaks buildworld Message-ID: <20211222193725.19f2f03a@ernst.home> In-Reply-To: <CANCZdfqAdO1HMDnWMsEU1LarRj36GzA%2Bog%2BxGkBY6rziA_yLWQ@mail.gmail.com> References: <20211219114723.338b235e@ernst.home> <61bf1204.1c69fb81.2c8fc.3280SMTPIN_ADDED_BROKEN@mx.google.com> <20211219122443.1c84093f@ernst.home> <CAGgez=%2B_jdDn6dfOeo%2BuBeeFNzBfD57HL4wUrw=X-BmGg7mPyg@mail.gmail.com> <74FC7625-295C-4DEC-BF35-434B5F8D7832@FreeBSD.org> <20211222165154.33ef54fd@ernst.home> <20211222170151.05a4afe3@ernst.home> <CANCZdfqAdO1HMDnWMsEU1LarRj36GzA%2Bog%2BxGkBY6rziA_yLWQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 22 Dec 2021 10:58:50 -0600
Warner Losh <imp@bsdimp.com> wrote:
> On Wed, Dec 22, 2021, 10:02 AM Gary Jennejohn <gljennjohn@gmail.com> wrote:
>
> >
> > This simple patch to /usr/src/include/Makefile fixes it for me:
> >
> > --- Makefile.orig 2021-12-22 13:37:02.817745000 +0100
> > +++ Makefile 2021-12-22 13:37:12.177336000 +0100
> > @@ -246,9 +246,7 @@
> > INCSGROUPS+= IPFILTER
> > .endif
> >
> > -.if ${MK_PF} != "no"
> > INCSGROUPS+= PF
> > -.endif
> >
> > .if ${MK_CDDL} != "no"
> > INCSGROUPS+= NVPAIR
> >
> > Since pf.h is used so widely in the tree it's probably the simplest fix.
> >
>
> I like this. I'd unconditionally remove the test in preference to adding it
> conditionally.
>
If I still had my commit bit I'd do it myself :-)
--
Gary Jennejohn
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20211222193725.19f2f03a>