Date: Thu, 20 Mar 2014 08:29:27 +0900 From: Julio Merino <jmmv@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: kyua requirement testing for tap tests Message-ID: <CAFY7cWCz17-7%2B_M5530uernH4NMz9YhDy6sbmJXpqehXJuR96w@mail.gmail.com> In-Reply-To: <CAOtMX2hJRRiEoS3g_Bp_c0D-bmZ7CKKF5udDNrL1kXWc2nb6BA@mail.gmail.com> References: <16437CC5729B5345AF77F816513376E812981CA4@MX103CL02.corp.emc.com> <CAOtMX2hJRRiEoS3g_Bp_c0D-bmZ7CKKF5udDNrL1kXWc2nb6BA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 20, 2014 at 8:05 AM, Alan Somers <asomers@freebsd.org> wrote: > On Wed, Mar 19, 2014 at 3:47 PM, Peel, Casey <casey.peel@isilon.com> wrot= e: >> The src/usr.sbin/sed/tests/multi_test.sh test requires the /usr/share/di= ct/words file but it doesn't explicitly state this. We don't ship that file= and thus the test fails. What is the correct way to specify requirements f= or tap tests such that kyua skips this test if it doesn't exist? The only o= ption I've come up with thus far is commenting out the multi_test suite alt= ogether from the Makefile. > > You need to set the required_files metadata variable for the test > program. I don't think that the TAP API has a way to do that, but can > you do it in the Kyuafile like this? > > tap_test_program(name=3D"multi_test", required_files=3D"/usr/share/dict/w= ords") Yes you can. (Note that those parenthesis ought to be braces though.) And you could do: TEST_METADATA.multi_test+=3D required_files=3D"/usr/share/dict/words" in the Makefile to avoid having to write a Kyuafile by hand. Fixed in r263388; thanks!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFY7cWCz17-7%2B_M5530uernH4NMz9YhDy6sbmJXpqehXJuR96w>