Date: Tue, 18 Sep 2012 20:15:16 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Ermal Lu?i <eri@FreeBSD.org> Cc: Sergey Kandaurov <pluknet@FreeBSD.org>, freebsd-pf@FreeBSD.org Subject: Re: svn commit: r240646 - head/sys/contrib/altq/altq Message-ID: <20120918161516.GG85604@glebius.int.ru> In-Reply-To: <CAPBZQG3JbsCOMAvYrOjVyRhbS6pfWxnyoaaMO8B%2BHp=pUdXk_A@mail.gmail.com> References: <201209181234.q8ICYaFB091109@svn.freebsd.org> <CAE-mSOJFHSSTmOBYYqUQkF3s_zK4aGTz2GXZWRo-ZfzJmhZazQ@mail.gmail.com> <CAPBZQG3JbsCOMAvYrOjVyRhbS6pfWxnyoaaMO8B%2BHp=pUdXk_A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ermal,
On Tue, Sep 18, 2012 at 06:02:06PM +0200, Ermal Lu?i wrote:
E> The issue is that this hides the problem per se.
What had hidden problem per se, was the following code:
PF_UNLOCK();
error = altq_add(a2);
PF_LOCK();
That's what we have in stable/9.
E> The ioctl and pfctl loading of ruleset is not ready for handling failures here!
They do. Error from altq_add() is returned by pf_ioctl() as response
to DIOCADDALTQ command. The code in pfctl, which does DIOCADDALTQ also
is handling errors.
--
Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120918161516.GG85604>