Date: Mon, 13 Jan 1997 21:56:17 +0100 (MET) From: Arjan.deVet@adv.IAEhv.nl (Arjan de Vet) To: imp@village.org Cc: freebsd-current@freebsd.org Subject: Re: ppp changes for buffer overflows going in Message-ID: <199701132056.VAA09476@adv.IAEhv.nl> In-Reply-To: <E0vibeK-00075I-00@rover.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In article <E0vibeK-00075I-00@rover.village.org> you write:
>However, I am unable to test ppp to my level of satisfaction easily,
>since I don't have a ppp link to test it with. I think these changes
>will be good, but thought I'd give a heads up.
In command.c the size of VarDialScript is being used for VarLoginScript:
diff -u -w -r1.28 command.c
--- command.c 1997/01/10 07:53:23 1.28
+++ command.c 1997/01/12 16:35:15
@@ -933,7 +934,7 @@
VarDialScript[sizeof(VarDialScript)-1] = '\0';
break;
case VAR_LOGIN:
- strncpy(VarLoginScript, *argv, sizeof(VarDialScript)-1);
+ strncpy(VarLoginScript, *argv, sizeof(VarLoginScript)-1);
VarLoginScript[sizeof(VarLoginScript)-1] = '\0';
break;
case VAR_DEVICE:
>They are 2.2 candidates, but I'd like to have them be tested in
>-current for as long as possible before committing to the 2.2 branch.
Everything seems to be working fine. In my own copy I have enlarged the
buffersizes for chat scripts because I have a chat script dealing with
SecurId cards and dialback and that takes more than the default 200
characters and maximum 20 expect/send pairs.
Arjan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199701132056.VAA09476>