Date: Sat, 1 Jul 2006 16:20:03 -0400 From: Anish Mistry <mistry.7@osu.edu> To: freebsd-stable@freebsd.org Cc: tbyte@otel.net Subject: Re: Bug in ata (ata-all.c) driver Message-ID: <200607011620.18085.mistry.7@osu.edu> In-Reply-To: <E1FwUo1-000666-32@mail.otel.net> References: <E1FwUo1-000666-32@mail.otel.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart4005420.eXet3BmkSX Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday 30 June 2006 22:01, tbyte@otel.net wrote: > I found a little bug (probably) in sys/dev/ata-all.c which somehow > corrupts device parameters structure. When I first did "atacontrol > list" device info about ad0 looked like this: > Master: ad0 <Maxtor 6Y080P0/YAR41BW0> ATA/ATAPI revision 7 > after I ran "atacontrol cap ad0" it printed somewhat messy output > like having enabled SMART but not supported... > then I did "atacontrol list" again and saw that the line about ad0 > have changed to something like this: > Master: ad0 <W0Maxtor 6Y080P0/YAR41BW0> ATA/ATAPI revision 0 > or similar. > > After some digging and comparing the way "IOCATADEVICES" and > "IOCATAGPARM" work I saw (probably) bogus ata_getparam() call. > After removing this call to ata_getparam() everything work as > expected (atleast that's what it looks like for ~30 min run). > "atacontrol cap ad0" shows right results and doesn't screw the > device parameters. I just hope that this doesn't break something > else but I doubt it coz it just gets info and doesn't set anything. > > The "giant" patch is attached. It's agains today's -STABLE. Don't forget to open a PR for this issue, so it doesn't get lost. =2D-=20 Anish Mistry --nextPart4005420.eXet3BmkSX Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBEptkCxqA5ziudZT0RAiPWAKDNdCp3tZBTkxAPTvm8hnm9sr+vkwCcDyCP Xtu3uHqlax3lgMaI+LDfqgg= =V727 -----END PGP SIGNATURE----- --nextPart4005420.eXet3BmkSX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607011620.18085.mistry.7>