Date: Mon, 31 Jan 2005 17:01:26 +0200 From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com> To: Palle Girgensohn <girgen@FreeBSD.org> Cc: freebsd-ports@freebsd.org Subject: Re: [HEADS UP] PostgreSQL ports split into -server & -client Message-ID: <20050131170126.43e2dc78@it.buh.tecnik93.com> In-Reply-To: <F06BEBCACCAC1B598D4B7D4D@rambutan.pingpong.net> References: <E200B81EA7454A9AFA88A1CF@palle.girgensohn.se> <E200B81EA7454A9AFA88A1CF@palle.girgensohn.se> <20050131025453.GA81974@nowhere> <Tfhyg1zblY@dmeyer.dinoex.sub.org> <20050131153816.128e4623@it.buh.tecnik93.com> <F06BEBCACCAC1B598D4B7D4D@rambutan.pingpong.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 31 Jan 2005 15:51:27 +0100
Palle Girgensohn <girgen@FreeBSD.org> wrote:
>=20
>=20
> --On m=E5ndag, januari 31, 2005 15.38.16 +0200 Ion-Mihai Tetcu=20
> <itetcu@people.tecnik93.com> wrote:
>=20
> > On Mon, 31 Jan 2005 07:49:34 +0100
> > dirk.meyer@dinoex.sub.org (Dirk Meyer) wrote:
> >
> >> Craig Boston schrieb:,
> >>
> >> > With 8.0 out and and 7.x likely continuing to be used in production
> >> > environments for quite some time, it would be nice to have a standard
> >> > way to select which combination of version and server/client to be
> >> > used (if there isn't one already; I'm about to go look at the new
> >> > ports).
> >>
> >> I used this macro in bind9-dlz/Makefile:
> >> POSTGRESQL_PORT?=3D databases/postgresql7
> >> LIB_DEPENDS=3D pq.3:${PORTSDIR}/${POSTGRESQL_PORT}
> >
> > What about a user settable WITH_PGSQL_VER equivalent of
> > DEFAULT_PGSQL_VER like in MySQL case ?
> >
> >
> > And: I've set in my mail/dspam's Makefile:
> > ......
> > .if defined(WITH_POSTGRESQL)
> > USE_PGSQL=3D yes
> > + WANT_PGSQL_VER=3D 99
> > + DEFAULT_PGSQL_VER=3D 99
> > + BROKEN_WITH_PGSQL=3D 74
> > .......
> >
> > and it doesn't complain, just goes on and compiles with the install
> > headers; having this installed:
> > # pkg_info -I postg\*
> > postgresql-7.4.6 The most advanced open-source database available
> > anywhere postgresql-docs-7.4.6 The PostgreSQL documentation set
> >
> > And I don't understand it, it should bark on this else:
> ># And now we are checking if we can use it
> > .if exists(${PORTSDIR}/databases/postgresql${PGSQL_VER}-client)
> > ......
> > .else
> > BROKEN=3D "unknown PostgreSQL version: ${PGSQL_VER}"
>=20
> Well, in this case it is because pre.mk is loaded *before* the variables=
=20
> are set. Hmm, this seems like a bug, but it works, kind of... I would hav=
e=20
> believed that USE_PGSQL would not work either in this case, but it does.=
=20
> This surprises me a bit.
>=20
> Standard procedure is to set stuff like USE_PGSQL, WITH_PGSQL_VER and=20
> BROKEN_WITH_PGSQL etc *before* including <bsd.port(.pre)?.mk>.
Maybe portlint should yes a warning if not ?
>From what I can tell, it should work when set in ENV or command line,
right ? And that would count as " before bsd.* " ? But it doesn't.
> There is a catch-22 when using OPTIONS, though...the OPTIONS stuff is not=
=20
> competent enought, really. You need to include <bsd.port.pre.mk> in order=
=20
> to read stuff from OPTIONS, but then it is too late for setting USE_XXX=20
> knobs... :(
I was thinking about splitting the port in 3 slaves - one for each DB
and a master and this would serve also as a kind of workaround in this
case.
> But you're right that it does not do exactly what I would expect in this=
=20
> case. I'll look into it tonight,
Thanks.
--=20
IOnut
Unregistered ;) FreeBSD "user"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050131170126.43e2dc78>