Date: Sat, 17 Oct 2015 07:44:27 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Dimitry Andric <dim@FreeBSD.org> Cc: Garrett Cooper <ngie@FreeBSD.org>, "jenkins-admin@FreeBSD.org" <jenkins-admin@FreeBSD.org>, "freebsd-current@FreeBSD.org" <freebsd-current@FreeBSD.org> Subject: Re: FreeBSD_HEAD_amd64_gcc4.9 - Build #673 - Failure Message-ID: <BA348C9C-A812-4BE2-B1E6-EFFE5C905F86@FreeBSD.org> In-Reply-To: <F3DFF8C1-4D8D-4A29-B102-CA6A19B131E2@FreeBSD.org> References: <1743862498.27.1445058611319.JavaMail.jenkins@jenkins-9.freebsd.org> <5621D9F1.9080707@FreeBSD.org> <5621DDB1.8020807@FreeBSD.org> <31F4FEC4-B677-4EA1-BD67-F2DC458A99E4@gmail.com> <2B9A4B89-6D0D-4549-B249-FB30A8117DDF@gmail.com> <78883694-7B54-4AC3-9B5B-D715D5DA1F88@gmail.com> <F3DFF8C1-4D8D-4A29-B102-CA6A19B131E2@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Oct 17, 2015, at 04:11, Dimitry Andric <dim@FreeBSD.org> wrote:
>=20
>> On 17 Oct 2015, at 09:09, NGie Cooper <yaneurabeya@gmail.com> wrote:
>> ...
>> Also, this logic looks troublesome:
>>=20
>> 42 .if empty(TOOLSDIR) || !exists(${TOOLSDIR}/usr/bin/clang-tblgen)
>> 43 .if ${MACHINE} =3D=3D "host" && defined(BOOTSTRAPPING_TOOLS)
>> 44 .if !empty(LEGACY_TOOLS) && exists(${LEGACY_TOOLS}/usr/bin/tblgen)
>> 45 TOOLSDIR=3D ${LEGACY_TOOLS}
>> 46 .endif
>> 47 .endif
>> 48 .if ${MK_STAGING} =3D=3D "yes" && exists(${STAGE_HOST_OBJTOP:Uno}/usr/=
bin/tblgen)
>> 49 TOOLSDIR=3D ${STAGE_HOST_OBJTOP}
>> 50 .endif
>> 51 .if exists(${LEGACY_TOOLS:Uno}/usr/bin/tblgen)
>> 52 TOOLSDIR=3D ${LEGACY_TOOLS}
>> 53 .endif
>> 54 .endif
>> 55 TOOLSDIR?=3D
>> 56 .if !empty(TOOLSDIR) && exists(${TOOLSDIR}/usr/bin/clang-tblgen)
>> 57 TBLGEN=3D ${TOOLSDIR}/usr/bin/tblgen
>> 58 CLANG_TBLGEN=3D ${TOOLSDIR}/usr/bin/clang-tblgen
>> 59 .endif
>> 60 TBLGEN?=3D tblgen
>> 61 CLANG_TBLGEN?=3D clang-tblgen
>>=20
>> This kind of complexity matched something that I simplified at $work due t=
o build races=E2=80=A6
>=20
> This stuff was added by sjg as part of his meta-mode commit frenzy in
> r284345, but I never really agreed to it, nor do I understand what its
> function is. It was just splattered all over the tree.
>=20
> Can we just remove it for now, and put it back when it works, and is
> actually used for something? :-)
It is used only for meta mode.
>=20
> -Dimitry
>=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BA348C9C-A812-4BE2-B1E6-EFFE5C905F86>