Date: Sat, 10 May 2014 18:39:01 -0400 From: Shawn Webb <lattera@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: freebsd-current@freebsd.org Subject: Re: Recent Changes to WITH_*/WITHOUT_* in src Message-ID: <20140510223901.GV3063@pwnie.vrt.sourcefire.com> In-Reply-To: <F5E246EB-BCB7-48A4-9540-935D8D9B1F05@bsdimp.com> References: <20140510164512.GS3063@pwnie.vrt.sourcefire.com> <73589111-84D9-40EA-89F1-330396E853DA@bsdimp.com> <20140510212531.GT3063@pwnie.vrt.sourcefire.com> <F5E246EB-BCB7-48A4-9540-935D8D9B1F05@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--GTZ+2qEBTXdGs1w1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On May 10, 2014 03:29 PM -0600, Warner Losh wrote: >=20 > On May 10, 2014, at 3:25 PM, Shawn Webb <lattera@gmail.com> wrote: >=20 > > On May 10, 2014 02:14 PM -0600, Warner Losh wrote: > >>=20 > >> On May 10, 2014, at 10:45 AM, Shawn Webb <lattera@gmail.com> wrote: > >>=20 > >>> Hey All, > >>>=20 > >>> It seems that the recent changes to the makefiles for building > >>> world/kernel have broken some modifications I have locally for > >>> implementing ASLR+PIE. I'm quite the bsd make newbie, so I thought I'd > >>> ask for a bit of help. I'm sure the solution is quite simple. > >>>=20 > >>> My code is up on GitHub. I'll include links at the bottom of the emai= l. > >>>=20 > >>> The code in question is in share/mk/bsd.prog.mk, where I'm checking to > >>> see if MK_PIE is not equal to "no". Prior to the recent changes, this > >>> code used to work. (Please note that I know that the way I'm cheking = is > >>> a bit bloated, if anyone has any suggestions to trim my code down, let > >>> me know). > >>=20 > >> You?ll need to add PIE to DEFAULT_NO_OPTIONS in bsd.opts.mk since > >> bsd.*.mk files need it. > >>=20 > >=20 > > Thanks a lot! Adding it to that one worked. > >=20 > > But what's the difference between the DEFAULT_NO_OPTIONS in src.opts.mk= and > > bsd.opts.mk? >=20 > Options to build FreeBSD?s /usr/src are defined in src.opts.mk. Options t= ested by bsd.*.mk, which can be used to build other things, are in bsd.opts= =2Emk.=20 Cool. Thanks for the clarification. Do the options tested by bsd.opts.mk get parsed by the ports framework? I've added similar functionality to the ports framework, but maybe I can remove it in favor of bsd.opts.mk + bsd.prog.mk? Thanks, Shawn --GTZ+2qEBTXdGs1w1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJTbqmBAAoJEGqEZY9SRW7uNqEQAL7EvpGh41a6Z+l7accUhC5j KIo1bKe6xt8cTBpY/NJ9J7hGiqVxQl9TVGIAk6RpbhMLYqWkMsi0aZmSZ+XoIekp PKhQouARUXu88MQPu9lL75vQrVYT04e2llYQ7jpV6qOfn2pNEWM1EeoXpmuED9rP LX6pgDIKeWEth0Y0EAxlikZ4rH/tq6H1L7526SNFpPp7g6XQsgEETZpabSvgrsNn K5b2MrO1s1XrNiADeofgzOZ6uGktJWAI8skL534hQVLl6n0bHZyAWcbhCQJS9LM5 Q2J+e9CFRYU58T9aUXkG7LJHr1m/YIkahEC1lUqsLr/tk/qTvCb3A+r6jjVcvYOr msUeATmhktxXxs12rgzPbk54U0RF9cLMV9Zjp/uyzoWsObbbQgocaV15nmlUlFAc YdFuQoL3k/w+saVFYz8SnXqJSWect6j4MZ5U7gL/0vzvG7FJvePPUvot0icYkXfp apUOSedgrePkuNDP1xlHbJ+v87sQo1MozYm31uCOrPtSOlz7UAe9pjZ5mBDuJT9r GYPL4yjNQHUCbXShgoa0DRh7zW9zJ7Mo2q9a6WmqtL2133+t6fkWTIomH17f+luV Jhnp5lrm7S7uG6BvxQqHyFYBbitNT7Hn6A5j8QpRhImML0NNT+O/iM9Nm49yIKFI N1d65300O6osxRlS4sVq =DGnb -----END PGP SIGNATURE----- --GTZ+2qEBTXdGs1w1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140510223901.GV3063>