Date: Wed, 17 Jun 1998 00:25:03 -0400 From: Matthew Hunt <mph@pobox.com> To: ac199@hwcn.org, daetalus@his.com Cc: freebsd-ports@FreeBSD.ORG Subject: Re: Do Committers like ftp or diff Message-ID: <19980617002503.A348@flarn.dyn.ml.org> In-Reply-To: <Pine.BSF.3.96.980616232805.224A-100000@localhost>; from Tim Vanderhoek on Tue, Jun 16, 1998 at 11:32:56PM -0400 References: <199806162354.TAA00718@daetalus.his.com> <Pine.BSF.3.96.980616232805.224A-100000@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 16, 1998 at 11:32:56PM -0400, Tim Vanderhoek wrote: > !!diff -ur e93 e93_orig [ shouldn't that be -urN ? And the other way around? ] > From vi, of course. If you're using something else, I can't say > I have too much pity. ;-) Since I'm less vi-literate, I just make a patchfile: diff -urN myport.orig myport > ~/myport.diff I review it, for obvious stupidity (forgot "make clean", etc.): less ~/myport.diff And then, when editing my PR, I just insert the file. In vi, that would be ":r ~/myport.diff"; in Emacs, it would be "C-x C-i ~/myport.diff RET". > And the committers prefer diff. Except for the exceptions > documented in the handbook. Absolutely. Either you make the diff, or we have to. Strangely enough, we prefer that you do it. :-) Besides, you should run "diff" anyhow, to easily review the changes you're submitting. -- Matthew Hunt <mph@pobox.com> * Stay close to the Vorlon. http://www.pobox.com/~mph/pgp.key for PGP public key 0x67203349. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980617002503.A348>