Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 8 Jun 2000 15:14:19 -0700
From:      John-Mark Gurney <gurney_j@efn.org>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libc/sys kqueue.2
Message-ID:  <20000608151419.24215@hydrogen.funkthat.com>
In-Reply-To: <Pine.BSF.4.21.0006081937330.468-100000@besplex.bde.org>; from Bruce Evans on Thu, Jun 08, 2000 at 07:51:16PM %2B1000
References:  <200006072209.PAA95251@freefall.freebsd.org> <Pine.BSF.4.21.0006081937330.468-100000@besplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans scribbled this message on Jun 8:
> On Wed, 7 Jun 2000, John-Mark Gurney wrote:
> 
> > jmg         2000/06/07 15:09:16 PDT
> > 
> >   Modified files:
> >     lib/libc/sys         kqueue.2 
> >   Log:
> >   add a BUGS section on how we can only watch VNODE's on a UFS file system
> >   right now...
> >   
> >   I talked w/ phk last night and "fixing" this in a generic way is going
> >   to require a lot of complex thought on stacking let alone the NFS problems..
> 
> It can be duplicated in other fs's, just like mounds of other code is
> duplicated.  Duplication is especially easy in ext2fs where the surrounding
> code was duplicated (except where the duplicates have rotted).

yeh, I was thinking about that way too, but I don't like duplicating
code... of course phk suggested putting a FS layer in between.. :)

> >   add missing sys/time.h for struct timespec def...
> 
> This is bogus.  <sys/event.h> forward-declares struct timespec so that
> <sys/time.h> is not a prerequisite for <sys/event.h>.  <sys/time.h> only
> needs to be included when the complete type for struct timespec is needed.
> Even if kevent() is called, the complete type isn't needed unless the
> timeout arg is non-NULL and is constructed in the same file.  Anyway,
> POSIX.1-1996 says that struct timespec is declared in <time.h>.

so, is the correct fix to take it out of to change it to time.h?

-- 
  John-Mark Gurney				Voice: +1 408 975 9651
  Cu Networking		   "I say all sorts of useless things." -- cmc


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000608151419.24215>