Date: Sat, 23 Sep 2000 15:42:40 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Jason Evans <jasone@FreeBSD.org> Subject: Re: cvs commit: src/sys/i386/include mutex.h src/sys/alpha/inclu Message-ID: <XFMail.000923154240.jhb@FreeBSD.org> In-Reply-To: <Pine.BSF.4.21.0009240714570.9133-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23-Sep-00 Bruce Evans wrote: > On Fri, 22 Sep 2000, Jason Evans wrote: > >> jasone 2000/09/22 17:00:50 PDT >> >> Modified files: >> sys/i386/include mutex.h >> sys/alpha/include mutex.h >> Log: >> #include <sys/proc.h> in order to get curproc. This seems to be the >> #lesser >> of two evils; the greater evil is requiring sys/proc.h to be included >> before including machine/mutex.h. > > The correct implementation is none of the above: > >#ifndef SMP > extern struct proc *curproc; >#endif curproc is no longer a variable like that. It is now a #define to a function to extract per-cpu data. On UP systems, this is simplfied by having it just reference gd_curproc. This change would be a bug. Especially if you #include both proc.h and mutex.h in some other header. > Bruce -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.cslab.vt.edu/~jobaldwi/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.000923154240.jhb>