Date: Wed, 16 Jul 2008 18:44:07 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: freebsd-fs@freebsd.org Subject: Re: executable open until unmount Message-ID: <20080716154407.GG17123@deviant.kiev.zoral.com.ua> In-Reply-To: <Pine.GSO.4.63.0807161131280.5149@muncher.cs.uoguelph.ca> References: <Pine.GSO.4.63.0807151453130.12638@muncher.cs.uoguelph.ca> <20080715203641.GA17123@deviant.kiev.zoral.com.ua> <Pine.GSO.4.63.0807161131280.5149@muncher.cs.uoguelph.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, Jul 16, 2008 at 11:32:28AM -0400, Rick Macklem wrote:
> Patch looks good. It fixed my problem and hasn't crashed the system yet;-)
Did you tested both elf executables and #!-scripts ?
>
> Thanks, rick
>
> On Tue, 15 Jul 2008, Kostik Belousov wrote:
>
> >On Tue, Jul 15, 2008 at 02:57:23PM -0400, Rick Macklem wrote:
> >>I'm testing my nfsv4 client and I've run into this issue under FreeBSD7.0.
> >>
> >>When I execute a file on the nfs mounted volume, the file remains open
> >>until the vnode gets cleared out, usually when I unmount. For NFSv4, this
> >>isn't a particularily good thing, since these Opens tie up resources on
> >>the NFS server, etc.
> >>
> >>Anyone know if there is something I'm doing incorrectly that causes this
> >>or a way to get the close to happen when the executable terminates?
> >>
> >>Thanks in advance for any help, rick
> >
> >Try this:
> >
> >diff --git a/sys/kern/kern_exec.c b/sys/kern/kern_exec.c
> >index f4335a2..c3ef0e9 100644
> >--- a/sys/kern/kern_exec.c
> >+++ b/sys/kern/kern_exec.c
> >@@ -496,6 +496,7 @@ interpret:
> > interplabel = mac_vnode_label_alloc();
> > mac_vnode_copy_label(binvp->v_label, interplabel);
> >#endif
> >+ VOP_CLOSE(binvp, FREAD, td->td_ucred, td);
> > vput(binvp);
> > vm_object_deallocate(imgp->object);
> > imgp->object = NULL;
> >@@ -845,6 +846,7 @@ exec_fail_dealloc:
> > if (imgp->vp != NULL) {
> > if (args->fname)
> > NDFREE(ndp, NDF_ONLY_PNBUF);
> >+ VOP_CLOSE(imgp->vp, FREAD, td->td_ucred, td);
> > vput(imgp->vp);
> > }
> >
> >
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEARECAAYFAkh+F0cACgkQC3+MBN1Mb4heSQCglg90q/P8YyBmAt2BSlC+rovK
ek8AoNqF1sSuTmlU0sa6it8W6BC6ZoZ2
=7VvH
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080716154407.GG17123>