Date: Wed, 29 Nov 2000 11:48:26 -0800 From: Marcel Moolenaar <marcel@cup.hp.com> To: Daniel Eischen <eischen@vigrid.com> Cc: Alfred Perlstein <bright@wintelcom.net>, arch@FreeBSD.ORG Subject: Re: Modifying FILE to add lock Message-ID: <3A255D8A.7F5CFB26@cup.hp.com> References: <Pine.SUN.3.91.1001129134930.20431A-100000@pcnet1.pcnet.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Daniel Eischen wrote: > > > I have no objection as long as you bump the shared lib version > > from -stable. This would be a great time to do it. > > This would only be in -current (where the library versions have > already been bumped) and for our new libpthread. I agree. We should not MFC this. Library version bumps halfway on a -stable branch doesn't seem appropriate. Changing structures is not done, IMO. Anyway: In stdio.h I'm told that I should read the warning before changing the layout of struct __sFILE. There doesn't seem to be a warning anywhere in the header file, so I figure it must be the long comment before the struct declaration. The comment doesn't tell me what happens if I change the layout. It only tells me what certain fields are for and doesn't mention _offset at all, even though that field specifically references the warning. My point: We're hinted to be careful and cautious without actually being told why. Can someone tell me what problems we might expect if we add a new field, both specifically at the end and randomly within the structure? -- Marcel Moolenaar mail: marcel@cup.hp.com / marcel@FreeBSD.org tel: (408) 447-4222 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A255D8A.7F5CFB26>