Date: Fri, 12 Apr 2024 08:53:20 +0200
From: Mathieu Arnold <mat@freebsd.org>
To: Tatsuki Makino <tatsuki_makino@hotmail.com>
Cc: Gleb Popov <arrowd@freebsd.org>, "freebsd-ports@FreeBSD.org" <freebsd-ports@freebsd.org>
Subject: Re: In some places, WITH_${feature}_PORTS doesn't work
Message-ID: <6dzfc6cvav4ruai6yzeeqhy5o6pkcfxif6y5tj4vuezhay2uqe@dshkqacwra3m>
In-Reply-To: <SI2PR01MB5036545DADEF96C62C97F3E5FA052@SI2PR01MB5036.apcprd01.prod.exchangelabs.com>
References: <SI2PR01MB5036300AACCBCAE6FF4A9E44FA052@SI2PR01MB5036.apcprd01.prod.exchangelabs.com> <CALH631m9g%2BonVYD1do2grMj2LCC2prNbQZriog9TL=XzEBWQQQ@mail.gmail.com> <SI2PR01MB50365398DB2B37D3CDEB3994FA052@SI2PR01MB5036.apcprd01.prod.exchangelabs.com> <CALH631=d3XuYXqFQf6e73-saSm1-o7LhVQ41thuGG328mfqk0g@mail.gmail.com> <SI2PR01MB5036545DADEF96C62C97F3E5FA052@SI2PR01MB5036.apcprd01.prod.exchangelabs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--fynwscg4w4xcs3bo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 12, 2024 at 06:31:45AM +0900, Tatsuki Makino wrote: > Gleb Popov wrote on 2024/04/12 02:57: > > Should be fixed now by > > https://cgit.FreeBSD.org/ports/commit/?id=3D665b0219e541019b849fd5a1efd= f032081dcf610 >=20 > Thank you very much. >=20 > This would mean that there is more support for the use of _WITH_${feature= } and _WITHOUT_${feature} in the future. > It is expected that an underscore should be added before the variable WIT= H, i.e., if the following part is present in individual ports. No, no, you should not do that, variables starting with an underscore are private and should not be used outside of the file they were defined in. The commits in question have been reverted and we're working on a solution. --=20 Mathieu Arnold --fynwscg4w4xcs3bo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmYY2l9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6Fbwv/ZwgpiCYYjQYgH6AvloknChZ017AUBdwSTG+TQRfPfImbt5nbtpUEkH84 DOMC9Dq4PF/DwqLBDa4Cc3e3wfw/d8lgkvocfv4drHzjmftgSo4M7K2jBOt2KYsy iUYHcaBniNCQK3V5XqsX8GRZbnAHA5PQVtBfZxqLKItY9p8bAHZoQxhUKxZr7vi6 b4xbdEG4JCyt31KntoX5CrIIQtP+eqpEKMG/oAG5QZBNHcdd+GzkxxiX17+DmSk0 29TvWz4+zqEQ1Xrq164DsBw9B2bIpJ5KcRcjC63QOrgzerqufBZDOPEodKMyYuEy W0yqLil8WtFsAak2lgGlXOg99NqhWDZPH/ywKt9XBokQ060giKyXyTLrIxCKCFS6 KB/a/Du76UpZ0pDND7kJixsG9W9Br8Md27ZoWrcSAKRebN+z2IySG2xG8NgLqFz+ ssjhJRzGkOIbJXSxrcBfDdXOny+gm4wILlrUr54/UUh424/km8G+slrXjJAOOr6W HrJZXW9P =WKpX -----END PGP SIGNATURE----- --fynwscg4w4xcs3bo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6dzfc6cvav4ruai6yzeeqhy5o6pkcfxif6y5tj4vuezhay2uqe>