Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 31 Dec 2000 18:04:50 -0800 (PST)
From:      Matt Dillon <dillon@earth.backplane.com>
To:        John Baldwin <jhb@FreeBSD.ORG>
Cc:        current@FreeBSD.ORG
Subject:   Re: Current hangs...
Message-ID:  <200101010204.f0124oW47215@earth.backplane.com>
References:   <XFMail.001231175340.jhb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
:
:Why not this:
:
:s = splbio();
:TAILQ_FOREACH(bp, &vp->v_dirtyblkhd, b_vnbufs) {

    First rule when making simple bug fixes by copying working code from one
    source file to another is:  Dont try to optimize the code on the
    fly.

    Personally speaking, I don't find the FOREACH macros any more readable
    vs an explicit for loop.  They hide too much... like for example the
    fact that you are dependant on the current pointer remaining valid to
    get the next pointer in the loop.

					-Matt



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200101010204.f0124oW47215>