Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Feb 2001 23:35:12 +1100 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        Doug Rabson <dfr@nlsystems.com>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Peter Wemm <peter@FreeBSD.org>
Subject:   Re: cvs commit: src/sys/conf kmod.mk
Message-ID:  <Pine.BSF.4.21.0102282314150.2900-100000@besplex.bde.org>
In-Reply-To: <XFMail.010227143117.jhb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 27 Feb 2001, John Baldwin wrote:
> On 27-Feb-01 Doug Rabson wrote:
> > On Mon, 26 Feb 2001, Peter Wemm wrote:
> > 
> >> peter       2001/02/26 17:23:34 PST
> >> 
> >>   Modified files:
> >>     sys/conf             kmod.mk 
> >>   Log:
> >>   Add pci/agp_if.m to the MFILES list so that we can auto depend on agp_if.h
> > 
> > I wish I could think of a way to avoid listing all the .m files in MFILES.
> 
> This is just so we can build kernels w/o a make depend, yes?

Er, no.  It is so that module Makefiles don't have to know where the .m
files are.  See modules/agp/Makefile.  It still knows where agp_if.m is,
and even knows where other .m files are.  There seems to be a problem
in the setting of MFILES.  kmod.mk uses "MFILES?=", so indivual Makefiles
can't modify the default MFILES; they have to repeat everything.  Otherwise,
knowing where agp_if.m is in agp/Makefile would be reasonable -- only agp
uses it.

Listing all the .m files in MFILES is not really different from listing
all kernel source files in /sys/conf/files in /sys/conf/files*.  The
problem is that the lists are duplicated.  The duplication is worst
for .h files.  Some options headers must be duplicated in many module
Makefiles, but config(8) generates them automatically for kernels.
Peter's changes to make building modules more like building the kernel
will presumably have the side effect of fixing this.  I'm not sure how
they would avoid building zillions of options headers when you just
want to build a small module.  The information about which .c files
depend on which options headers is not available until `make depend'
has looked at all the source files, and this takes too long.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0102282314150.2900-100000>