Date: Mon, 29 Oct 2001 09:43:04 -0800 From: Luigi Rizzo <rizzo@aciri.org> To: John Baldwin <jhb@FreeBSD.ORG> Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, Josef Karthauser <joe@FreeBSD.ORG>, "Andrew R. Reiter" <arr@watson.org>, Bruce Evans <bde@zeta.org.au> Subject: Re: ipfw.c -- (was: cvs commit: src/sys/netinet ip_fw.h) Message-ID: <20011029094304.C1368@iguana.aciri.org> In-Reply-To: <XFMail.011029092702.jhb@FreeBSD.org> References: <20011029082644.E96115@iguana.aciri.org> <XFMail.011029092702.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 29, 2001 at 09:27:02AM -0800, John Baldwin wrote: > > > > i questioned the interpretation of "routine", not "block". > > Variable declarations that are 500 lines away are only calling for > > subtle bugs to be introduced when modifying the code (and we have > > plenty of very large functions in the kernel). > > Perhaps the large function needs to be split up then, and that is probably the surely large functions need to be split up. But i doubt it will ever happen for the whole ugly mess that we have in the IP stack: tcp_input 2000 lines tcp_output 800 lines ip_input 550 lines ip_output 800 lines ... and so on. I mean, i could imagine someone willing to bite the bullet and do a rewrite of the protocol stack, but i am sure that the result, however good it is, would never make it to stable because of fear of not having enough stability, or bug-by-bug conformance with the old testament code, or another Stevens (RIP) willing to document the new code. And given that there is no measurable performance problem it would be very hard to argue for the rewrite solely for "code quality" reasons. > and that is probably the > goal of this style(9) requirement. well, I'd rather hear this from whoever wrote that paragraph. cheers luigi ----------------------------------+----------------------------------------- Luigi RIZZO, luigi@iet.unipi.it . ACIRI/ICSI (on leave from Univ. di Pisa) http://www.iet.unipi.it/~luigi/ . 1947 Center St, Berkeley CA 94704 Phone: (510) 666 2927 ----------------------------------+----------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011029094304.C1368>