Date: Wed, 19 Dec 2001 11:13:11 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: John Baldwin <jhb@FreeBSD.org> Cc: freebsd-current@FreeBSD.org, Josef Karthauser <joe@tao.org.uk> Subject: Re: cvs commit: src/sys/kern vfs_subr.c vfs_vnops.c src/sys/sys Message-ID: <200112191913.fBJJDBu90110@apollo.backplane.com> References: <XFMail.011219110851.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
:> The structure is being bzero()'d before its dynamic flag gets checked. :> I've included a patch below. Josef, I would appreciate it if you would :> apply the patch and try your system with the various procfs devices :> mounted again. It's an obvious bug so I'm comitting it to -current now, :> the question is: Is it the *only* bug? :> :> -Matt : :Hmm, why bzero at all if you are just going to free it? Why not move the bzero :to an else after the ISDYNSTRUCT check? (Not that this is really all that :important, but... :) : :-- : :John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ He is invalidating the structure to catch references to deleted sbufs. (see assert_sbuf_integrity() calls). Josef, I take back my last request... I think there's another bug. Your vmstat -m output showed that both the sbuf pool and the VFS cache pool were blown up. The fix I just made will probably only solve the sbuf pool issue. If you still want to test it, observe both pools in the vmstat -m output carefully! -Matt Matthew Dillon <dillon@backplane.com> To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200112191913.fBJJDBu90110>