Date: Mon, 09 Sep 2002 13:29:55 -0700 From: "Bruce A. Mah" <bmah@FreeBSD.ORG> To: John Baldwin <jhb@FreeBSD.ORG> Cc: "Bruce A. Mah" <bmah@FreeBSD.ORG>, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/pkg_install/add main.c Message-ID: <200209092029.g89KTtoM045360@intruder.bmah.org> In-Reply-To: <XFMail.20020909161623.jhb@FreeBSD.org> References: <XFMail.20020909161623.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--==_Exmh_499224134P Content-Type: text/plain; charset=us-ascii If memory serves me right, John Baldwin wrote: > On 09-Sep-2002 Bruce A. Mah wrote: > > bmah 2002/09/09 12:44:17 PDT > > > > Modified files: > > usr.sbin/pkg_install/add main.c > > Log: > > Make pkg_install go to the right place for 4.6-RELEASE and 4.6.2-RELEASE > > packages. > > > > Pointed out by: obrien > > Reviewed by: jhb > > Actually, my bad, I think the upper limit for 4.6.2 should likely be 460099, > not 460100. Other than that, thanks! Urk. I just looked over the commit logs for param.h, and you're right, we should have used 460099 there. This would only cause a problem if someone had a pkg_add binary from a recent 4-STABLE or 4.6-STABLE (i.e. after this commit) but they were running it on an old 4-STABLE machine that had a __FreeBSD_version of 460100. Also, 460100 was only in use for 10 hours (plus 40 minutes, and 17 seconds). I guess I ought to go fix this up though, what do you think? For all you young (and not-so-young) src/ committers out there, this is an classic example of why insta-MFCs are bad (or at least risky). Had I waited a day (or even an hour) before doing my MFCs, I would have been able to read jhb's follow-up mail and actually MFC the right code. Bruce. --==_Exmh_499224134P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) Comment: Exmh version 2.5+ 20020506 iD8DBQE9fQTD2MoxcVugUsMRApPMAKDN5qMiWZv/CECm+UWhn3XOtIkhuwCgoZ3J ZPEgX785xaVOG5rXFoGqLNk= =Wamj -----END PGP SIGNATURE----- --==_Exmh_499224134P-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200209092029.g89KTtoM045360>