Date: Mon, 01 Nov 2021 13:35:55 +0800 From: Philip Paeps <philip@freebsd.org> To: Thomas Skibo <thomas-bsd@skibo.net> Cc: freebsd-riscv@freebsd.org Subject: Re: i2c driver for SiFive Unmatched Message-ID: <08F98357-4565-4791-8634-3ECFAA534B6F@freebsd.org> In-Reply-To: <YXw8VwEDP0mn64Eu@sherman> References: <YXMnqz1wsNSYaSlj@sherman> <0FE65505-39B1-42D7-B016-9122ECA098D3@freebsd.org> <YXw8VwEDP0mn64Eu@sherman>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2021-10-30 02:24:23 (+0800), Thomas Skibo wrote: > On Thu, Oct 28, 2021 at 11:40:34AM +0800, Philip Paeps wrote: >> On 2021-10-23 05:05:47 (+0800), Thomas Skibo wrote: >>> I have the OpenCores i2c driver (dev/iicbus/iicoc.c) up and running >>> on the >>> SiFive Unmatched. It was just a matter of adding the right >>> compatibility >>> strings and implementing iicoc_iicbus_repeated_start() which, oddly, >>> was >>> stubbed out. (Seems to me it should have returned an error if not >>> implemented.) >>> >>> I can put it up on Phabricator if there is interest. >> >> Yes please! > > It's up at https://reviews.freebsd.org/D32737 Awesome! Thanks for doing this work. I've just committed your changes to main. I'll merge them to stable/13 in a couple of days. As Jess suggested in the review, I've also added the driver to GENERIC. It's a small amount of code and it measurably lowers the friction of actually getting productive with a RISC-V board on FreeBSD. We've already got the SPI drivers in there too. And thanks for fixing the repeated start. I remember noticing this when I added the FDT attachment two years ago. I never had a chance to look into it more closely. Philip -- Philip Paeps Senior Reality Engineer Alternative Enterprises
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?08F98357-4565-4791-8634-3ECFAA534B6F>